Commit Graph

19046 Commits

Author SHA1 Message Date
Arthur Ozga
e7d2af0d72 remove duplicate verify 2017-08-17 20:06:34 -07:00
Ron Buckton
fad97e369a Remove debug assertions due to invalid syntax in generators transform 2017-08-17 17:32:06 -07:00
Andy
eef7d8bd3d Treat explicit imports from node_modules as external library imports (#16364)
* Treat explicit imports from `node_modules` as external library imports

* Update baselines
2017-08-17 13:26:38 -07:00
Nathan Shively-Sanders
a187b17e97 Simplify mapped-type handling in computeBaseConstraint 2017-08-17 13:09:21 -07:00
Nathan Shively-Sanders
1b4f90705f Test getConstraintOfIndexedAccess fixes and update baselines 2017-08-17 12:45:20 -07:00
Nathan Shively-Sanders
b8e0dedac0 Fix #17069 and #15371
1. `T[K]` now correctly produces `number` when
   `K extends string, T extends Record<K, number>`.
2. `T[K]` no longer allows any type to be assigned to it when
   `T extends object, K extends keyof T`.

Previously both of these cases failed in
getConstraintOfIndexedAccessType because both bases followed `K`'s base
constraint to `string` and then incorrectly produced `any` for types
(like `object`) with no string index signature. In (1), this produced an
error in checkBinaryLikeExpression`. In (2), this failed to produce an
error in `checkTypeRelatedTo`.
2017-08-17 12:40:10 -07:00
Andy
babb88a0aa Remove duplicate function (#17807) 2017-08-17 06:52:15 -07:00
Daniel Rosenwasser
2729281a14 Merge pull request #17631 from Microsoft/synthesizedNamespaces
Always emit leading 'var' declarations for synthesized namespaces
2017-08-16 23:56:07 -07:00
Daniel Rosenwasser
a38da8af70 Merge pull request #17838 from Microsoft/rev2.6.0
Bump version to 2.6.0.
2017-08-16 23:50:50 -07:00
Arthur Ozga
0d94d497df Merge pull request #16621 from aozgaa/formattingAfterParseError
Formatting after parse error
2017-08-16 20:49:29 -07:00
Arthur Ozga
bc0c9a440e Merge branch 'master' into formattingAfterParseError 2017-08-16 20:27:06 -07:00
Arthur Ozga
760ef44c36 test if onlyMultiLine flag changes answer 2017-08-16 18:48:27 -07:00
Arthur Ozga
6029b5cce8 cleanup 2017-08-16 18:12:28 -07:00
Arthur Ozga
19e2fa6fc5 Merge branch 'master' into isInMultiLineComment 2017-08-16 17:57:04 -07:00
Arthur Ozga
b7bc7d889e clarify JsxText handling 2017-08-16 17:56:20 -07:00
Arthur Ozga
23ca368020 Use simpler indentation for comments
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.

Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Arthur Ozga
62f16bee55 add tests 2017-08-16 17:36:50 -07:00
Arthur Ozga
4b9f5a0f8f rename tests 2017-08-16 17:36:39 -07:00
Arthur Ozga
70e4f346bb update test 2017-08-16 17:35:14 -07:00
Arthur Ozga
153b94aeb4 JsxText has no leading comments 2017-08-16 15:28:47 -07:00
Daniel Rosenwasser
b7020628c1 Addressed code review feedback. 2017-08-16 15:06:51 -07:00
Daniel Rosenwasser
3f50f20d0a Updated version in 'src' as well. 2017-08-16 14:49:44 -07:00
Andy
d4fecd4e46 Have grammarErrorAtPos take the source file of its argument (#17834) 2017-08-16 14:48:58 -07:00
Andy
9bcbc97e14 Replace 'isSourceFileJavaScript(getSourceFileOfNode())' with 'NodeFlags.JavaScriptFile' (#17835) 2017-08-16 14:48:46 -07:00
Andy
54af8aa945 Array arguments to concat should be ReadonlyArrays (#17806) 2017-08-16 14:32:14 -07:00
Ryan Cavanaugh
af68a61ba7 Ignore scripts for types packages 2017-08-16 11:53:44 -07:00
Tycho Grouwstra
76fb6545a5 fix some copy-pasting error (#17766)
* fix some copy-pasting error

* update to reflect @ahejlsberg's feedback
2017-08-16 11:49:24 -07:00
Nathan Shively-Sanders
146f828919 Merge pull request #17710 from Microsoft/add-readonly-check-to-property-access-of-index-signature
Add readonly check to property access of index signature
2017-08-16 11:16:54 -07:00
Daniel Rosenwasser
afdd77f1f6 Bump version to 2.6.0. 2017-08-16 10:41:49 -07:00
Nathan Shively-Sanders
7809398ad4 Indexed-assignment readonly err is not unknownType
Now, in an assignment to an indexed access of a readonly property, the
resulting type is still the property's type. Previously it was
unknownType. This improves error reporting slightly by reporting some
errors that were previously missed.
2017-08-16 10:06:01 -07:00
Andy
34a55899be Remove unnecessary call to getApparentType (#17788) 2017-08-16 10:04:51 -07:00
Anders Hejlsberg
ce2ac1751e Merge pull request #17771 from Microsoft/fixCircularContextualType
Fix circular contextual return type error
2017-08-16 09:17:15 +02:00
Arthur Ozga
ad9c29b928 add test 2017-08-15 12:44:21 -07:00
Paul van Brenk
b07fd3e180 Fix linter issues 2017-08-15 12:27:02 -07:00
Andy
93abebc04a Change function name to camelCase (#17751) 2017-08-15 12:26:00 -07:00
Daniel Rosenwasser
281d821fe8 Fix lint errors. 2017-08-15 12:16:54 -07:00
Arthur Ozga
a08d18af57 consolidate isInComment and getRangeOfEnclosingComment 2017-08-15 12:09:43 -07:00
Arthur Ozga
a209db7bb6 dont compute preceding token twice 2017-08-15 12:09:02 -07:00
Arthur Ozga
f3e0cbbd52 findPrecedingToken handles EOF child more gracefully 2017-08-15 12:09:02 -07:00
Arthur Ozga
472ad9d313 findPrevious changes 2017-08-15 12:08:00 -07:00
Arthur Ozga
b2188ad66c cleanup 2017-08-15 12:08:00 -07:00
Ryan Cavanaugh
eb8f7bddc2 Merge pull request #17796 from basarat/patch-1
Fix build 🌹
2017-08-15 11:06:33 -07:00
Andy
7409648416 Remove unused UseTypeAliasValue flag (#17779) 2017-08-15 10:24:15 -07:00
Andy
10c8d5effa In services, show the aliasSymbol for a type even if it's not accessible in the current scope (#17433)
* In services, show the aliasSymbol for a type even if it's not accessible in the current scope

* Rename flag
2017-08-15 10:23:45 -07:00
Basarat Ali Syed
c4dd820564 export interfaces used by exported functions 🌹 2017-08-15 15:19:40 +10:00
Basarat Ali Syed
e7ddaa7d49 export ScopeUsages 🌹 2017-08-15 15:17:19 +10:00
Daniel Rosenwasser
6e60a017bb Accepted baselines. 2017-08-14 21:24:51 -04:00
Daniel Rosenwasser
a51397e339 Just track the local names of identifiers instead of ever using symbols. 2017-08-14 21:24:30 -04:00
Paul van Brenk
5665c098da Introduce the concept of a Dynamic File
Dynamic files are generally created by the debugger when while debugging
it can't find a matching file on disk. Since these files don't exist on
disk, we shouldn't check if the file exists on disk, and allow the content
to be controlled by the host.
2017-08-14 16:55:37 -07:00
Andy
80a7ed9a42 Fixes to session's handling of empty results (#17728)
* Fixes to session's handling of empty results

* Fix emptyArray -> undefined
2017-08-14 13:42:15 -07:00