csigs
63a72636a9
LEGO: check in for master to temporary branch.
2018-05-17 04:10:22 +00:00
王文璐
755b443b6d
disallow acesssor generate in function like initializer
2018-05-17 10:18:20 +08:00
Wesley Wigham
159c808a0d
Sort the whole diagnostic, plus giving up on isolating tests ( #24186 )
...
* Sort the whole diagnostic
* Also strip references to our repos node_modules, since removing it is hard
2018-05-16 18:17:59 -07:00
Anders Hejlsberg
027829fbcd
Properly handle edge cases
2018-05-16 16:26:37 -07:00
Mohamed Hegazy
6af5d8b940
Add Unicode ThirdPartyNotice
2018-05-16 15:44:59 -07:00
csigs
67046799c2
LEGO: Merge pull request 24183
...
LEGO: Merge pull request 24183
2018-05-16 15:11:21 -07:00
csigs
7c52cab219
LEGO: check in for master to temporary branch.
2018-05-16 22:11:01 +00:00
Mohamed Hegazy
6f041e9379
Accept baselines
2018-05-16 14:26:34 -07:00
Mohamed Hegazy
3a00ac1d0b
Merge branch 'master' into updateVersion
2018-05-16 14:21:19 -07:00
Mohamed Hegazy
21acf4f783
Merge pull request #24136 from Microsoft/inferFromUsageFixes
...
Remove assert in `symbolToParameterDeclaration`
2018-05-16 14:15:37 -07:00
Andrew Casey
bc79917282
Merge pull request #24178 from amcasey/SyntaxServerOpenFileTelemetry
...
Don't collect open-file telemetry on the syntax server
2018-05-16 14:10:36 -07:00
Wesley Wigham
d70da6478a
Use newer signature help check ( #24179 )
2018-05-16 13:53:40 -07:00
Mohamed Hegazy
d55837175c
Update version
2018-05-16 13:50:48 -07:00
Andrew Casey
0b89460c18
Don't collect open-file telemetry on the syntax server
...
It's throwing an exception (since there's no program from which to
retrieve the SourceFile) and there's no reason to fix it since the
same files are open in the semantic server.
2018-05-16 13:40:24 -07:00
Wesley Wigham
a9ff9c2231
Have the bot link the build associated with the PR ( #24176 )
2018-05-16 13:12:17 -07:00
Wesley Wigham
d9cf2bed44
Merge branch 'master' of github.com:Microsoft/TypeScript
2018-05-16 13:11:36 -07:00
Wesley Wigham
a85f1d5c1e
Fix lint
2018-05-16 13:11:25 -07:00
Wesley Wigham
e01c7d23e1
Correctly show instantiated signatures for JSX element signature help and quick info ( #23492 )
...
* Correctly show instantiated signatures for JSX element signature help
* Also bundle fix for quickinfo
* Use more complete cache to avoid duplicate errors
2018-05-16 13:09:54 -07:00
Wesley Wigham
5bf6e30f8e
Use jsdoc aliases if visible when printing types ( #24153 )
...
* Use jsdoc aliases if visible when printing types
* Modify implementation a bit, add test that aughta change in the new future
* Accept baselines- hold off on typedef template lookup change
2018-05-16 12:58:36 -07:00
Wesley Wigham
15c09ef66b
Add temp module dir to gitignore to reduce git intellisense load when running user tests
2018-05-16 12:45:27 -07:00
Wesley Wigham
e509ee59df
Have bot force push his branch so he can run multiple times a day
2018-05-16 12:44:03 -07:00
Wesley Wigham
f0997c1e50
Merge branch 'master' of github.com:Microsoft/TypeScript
2018-05-16 12:42:59 -07:00
Wesley Wigham
8ce581149c
Bump user test enumeration timeout
2018-05-16 12:42:46 -07:00
Andy
424dba1d69
codeFixInferFromUsage: Avoid duplicate fix for variable declaration ( #24169 )
...
* codeFixInferFromUsage: Avoid duplicate fix for variable declaration
* Include VariableDeclaration initializer as a candidate type
2018-05-16 12:28:27 -07:00
Mohamed Hegazy
13ac88647f
Merge pull request #24162 from Kingwl/fix-generate-accessor-starting-underscore
...
fix generate accessor if starting with underscore
2018-05-16 12:06:15 -07:00
Mohamed Hegazy
aab8d65107
Update authors for release-2.9
2018-05-16 11:04:37 -07:00
Mohamed Hegazy
7f8ddc8343
Merge pull request #24158 from Kingwl/fix-trailing-comma-in-accessor-generator
...
fix trailing comma in accessor generator
2018-05-16 10:36:31 -07:00
Mohamed Hegazy
e923016463
Merge pull request #24160 from KSXGitHub/patch-1
...
Give checklist checkboxes
2018-05-16 10:34:01 -07:00
Wesley Wigham
60df4671d0
Fix jsx element parsing within ternary ( #24149 )
2018-05-16 09:28:22 -07:00
Mine Starks
dff5809c68
Accept new baseline
2018-05-16 09:27:14 -07:00
csigs
62921d56d6
LEGO: Merge pull request 24171
...
LEGO: Merge pull request 24171
2018-05-16 09:10:55 -07:00
csigs
06eabf7498
LEGO: check in for master to temporary branch.
2018-05-16 16:10:34 +00:00
Ryan Cavanaugh
32c43bbbcc
Merge pull request #24161 from KSXGitHub/patch-2
...
Give issue template's checklist checkboxes
2018-05-17 03:43:16 +12:00
csigs
c3df6edf24
LEGO: Merge pull request 24163
...
LEGO: Merge pull request 24163
2018-05-16 03:10:50 -07:00
csigs
da3724e793
LEGO: check in for master to temporary branch.
2018-05-16 10:10:29 +00:00
王文璐
b7f725d1b8
fix generate accessor if starting with underscore
2018-05-16 15:34:11 +08:00
Khải
4264629f2f
Give issue template's checklist checkboxes
...
Prior to this commit, checkboxes appear as pairs of brackets rather than proper checkboxes
2018-05-16 14:00:58 +07:00
Khải
b79986e99c
Give checklist checkboxes
...
Prior to this commit, checkboxes appear as bracket pairs instead of checkboxes.
2018-05-16 13:58:10 +07:00
王文璐
0fde07f1c5
fix trailing comma in accessor generator
2018-05-16 14:47:44 +08:00
csigs
ea2bc4c014
LEGO: Merge pull request 24157
...
LEGO: Merge pull request 24157
2018-05-15 23:39:14 -07:00
csigs
c52b069922
LEGO: check in for master to temporary branch.
2018-05-16 06:38:51 +00:00
Mohamed Hegazy
6f4ed3afa6
Handel synthetic rest parameter declarations
2018-05-15 22:08:01 -07:00
Andy
b4ca23d8f9
Fix bug: Converting 'module.exports = {...}' to ES6 doesn't introduce a default export ( #24141 )
2018-05-15 16:22:58 -07:00
Andy
2200c94a43
Fix unused diagnostic for rename-destructuring { a: b } ( #24145 )
2018-05-15 16:22:13 -07:00
Andy
d4a3c9c61a
Fix placement of indent for @ts-ignore comment ( #24143 )
2018-05-15 16:21:15 -07:00
Nathan Shively-Sanders
339a56fbf0
Avoid duplicates when finding jsdoc ( #24086 )
...
* Avoid duplicates when finding jsdoc
1. Add a cheap assert for detecting duplicates. getJSDocTags must find
either [1] 0 or 1 comments or [2] the first two comments must not be
identical. This does not always find duplicates for nodes with 3 or more
comments, but these nodes are exceptionally rare.
This assert fired for over 20 of the around 250 tests we have that
retrieve JSDoc at all. So I fixed the asserts in [2] and [3].
2. There were overlapping cases from calls to getSourceOfAssignment and
getSpecialPropertyAssignment. getSpecialPropertyAssignment is too
restrictive, but was in the correct location (parent vs parent.parent),
so I removed the getSourceOfAssignment call and replaced the
getSpecialPropertyAssignment calls with a less restrictive check.
3. When a node's parent is a PropertyDeclaration,
getJSDocCOmmentsAndTags would check the parent for jsdoc. But when the
*node* is a PropertyDeclaration, getJSDocCommentsAndTags would use the
jsdoc from the initializer. This second case is useful to make sure that
property declarations get all their jsdoc, but results in duplicates for
their initializers. I couldn't think of a better fix than tracking the
previous node in the recursive lookup of getJSDocCommentsAndTags, which
is a little clunky.
* Fix lint; remove new context parameter
* Update importJsNodeModule3 with fix
2018-05-15 15:12:29 -07:00
Mine Starks
0ab3c1fe96
Normalize this.currentDirectory
2018-05-15 14:34:24 -07:00
Sheetal Nandi
77168e5d50
Merge pull request #24112 from Microsoft/packageJsonWithMainInSubDirectory
...
Resolve using package json's "main" field when resolving typescript extensions
2018-05-15 14:18:27 -07:00
Andy
cbbe34b35e
Fix conversion of TextChanges to FileCodeEdits for new file ( #24126 )
2018-05-15 13:55:26 -07:00
Wesley Wigham
86dce41ec0
Move synthetic comments from arrow body expressions to return statement ( #24135 )
2018-05-15 13:11:38 -07:00