21651 Commits

Author SHA1 Message Date
Andrew Casey
3a38c8ea58 Replace TextChangesContext with RefactorOrCodeFixContext
Thanks to @andy-ms for the suggestion!
2018-01-17 15:43:36 -08:00
Sheetal Nandi
8e35c3103d
Merge pull request #21244 from Microsoft/allowNonExistentInputInGetDirectories
Fix the invalid file/directory location when getting file system entries for caching the results
2018-01-17 15:39:49 -08:00
Andrew Casey
13bf7f9c7c Ensure getNewLineFromContext never returns undefined 2018-01-17 15:37:05 -08:00
Andrew Casey
3ca1cc406a Clean up TODOs for #18445 2018-01-17 15:29:41 -08:00
Ryan Cavanaugh
265a8b0011
Update issue_template.md 2018-01-17 15:21:15 -08:00
Wesley Wigham
99d6b0d308
Actually get the apparent type of intersection members when calculating intersection apparent types (#21133)
* Actually get the apparent type of intersection members when calculating intersection apparent types

* Add nonjsx variant

* Fix nit
2018-01-17 15:20:09 -08:00
Andrew Casey
db3f7c538e Update test baselines 2018-01-17 15:18:54 -08:00
Ryan Cavanaugh
f92e6a26c9
Update issue_template.md 2018-01-17 15:14:27 -08:00
Andrew Casey
b4a382bdd2 Stop explicitly storing newline in refactoring/code fix contexts
It's already in the EditorSettings and the LanguageServiceHost.

Fixes #18291
Fixes #18445
2018-01-17 15:14:03 -08:00
Andrew Casey
9a83077d78 Add explanatory comment 2018-01-17 15:12:39 -08:00
Sheetal Nandi
9ad9dc106c
Merge pull request #21171 from Microsoft/renameSymLinks
Rename through all projects with same file through symLink
2018-01-17 15:08:27 -08:00
Sheetal Nandi
41c02e6482
Merge pull request #20515 from Microsoft/fileAddedAfterProjectOpen
Update the project graph before checking if opened file is present in the existing project
2018-01-17 15:07:46 -08:00
Andrew Casey
5de6ac1a2f Simplify test cases 2018-01-17 15:06:54 -08:00
Andrew Casey
3b5689fa1f Add more test coverage for unusedParameterInLambda 2018-01-17 15:06:54 -08:00
Andrew Casey
e354754b2a Special case arrow functions with only parameter unused
Fixes GH #18274
2018-01-17 15:06:53 -08:00
Sheetal Nandi
8281c7a137 Fix the invalid file/directory location when getting file system entry for caching read directory results
Fixes #20607
2018-01-17 15:00:22 -08:00
Andy
1dcc83e6d2
Minor cleanup in getDynamicIndentation (#21240) 2018-01-17 14:29:19 -08:00
Andy
ec37651308
Use packageId for suggestion to install @types/packageName (#21241) 2018-01-17 14:22:58 -08:00
Mohamed Hegazy
b0d7d5a7ef
Fix #21089: Do not infer from numeric index signature in Object.values and Object.entries (#21129)
* Fix https://github.com/Microsoft/TypeScript/issues/21089: Do not infer from numeric index signature in Object.values and Object.entries

* Update test
2018-01-17 14:16:11 -08:00
Nathan Shively-Sanders
485ec34e8e Test assignability of indexed access types 2018-01-17 13:22:31 -08:00
Nathan Shively-Sanders
5c889299f4 Indexed access relation check object+index types
Previously, it only check the object types, and only if the index types
were identical. Now both checks call `isRelatedTo` recursively.
2018-01-17 13:21:10 -08:00
Ryan Cavanaugh
7e1e038cf3
Update issue_template.md 2018-01-17 13:17:56 -08:00
Anders Hejlsberg
4ec6fdd96f Merge branch 'master' into conditionalTypes
# Conflicts:
#	src/compiler/checker.ts
#	src/compiler/types.ts
#	tests/baselines/reference/api/tsserverlibrary.d.ts
#	tests/baselines/reference/api/typescript.d.ts
2018-01-17 13:12:36 -08:00
Ron Buckton
3c988e8f5a
Merge pull request #21215 from Microsoft/fix20461
Fixes var declaration shadowing in async functions
2018-01-17 13:08:18 -08:00
Ryan Cavanaugh
ea6d7e9175
Make issue template more enthusiastic 2018-01-17 12:44:03 -08:00
Andy
e248d08e4c
Combine repeatString helper functions (#21235) 2018-01-17 12:43:41 -08:00
Andy
f96dc84a70
Make getCombinedCodeFix API public (#21234) 2018-01-17 12:42:31 -08:00
Benjamin Lichtman
8f6c516ef9
Merge pull request #21205 from uniqueiniquity/resolveTripleSlashReferencePaths
Fix Windows-style absolute paths in triple-slash directives
2018-01-17 12:31:46 -08:00
Andy
8ed885db3e
Add completions from the 'this' type (#21231)
* Add completions from the 'this' type

* Code review
2018-01-17 12:05:31 -08:00
Mohamed Hegazy
48ac3019b4 Add example to command description 2018-01-17 11:59:01 -08:00
Mohamed Hegazy
33fd30250d update authors 2018-01-17 11:58:38 -08:00
Ron Buckton
5b45db7907 PR Feedback 2018-01-17 11:55:43 -08:00
Andy
b363f4f9cd
Log packageId in --traceResolution (#21233) 2018-01-17 11:41:23 -08:00
Ron Buckton
afaa139475 Namespaces do not have the same 'var' scope 2018-01-17 11:30:48 -08:00
Andy
c549bb5737
Fix bug: getNonNullableType before getting signatures of method (#21212) 2018-01-17 11:27:21 -08:00
Ron Buckton
e655446318 Add test for catch block without variable 2018-01-17 11:25:53 -08:00
Ron Buckton
2ba29d8d9d Support labeled statement 2018-01-17 11:24:28 -08:00
Ron Buckton
004f18ff0c
Merge pull request #21219 from Microsoft/fix19020
Fix destructuring assignment when assignment target is RHS
2018-01-17 11:22:30 -08:00
Andy
61fb845b87
Get packageId for relative import within a package (#21130)
* Get packageId for relative import within a package

* Code review

* Rename things and add comments

* Improve documentation

* Test for scoped packages
2018-01-17 11:14:03 -08:00
Ron Buckton
18a2fc82f7 Accept tsserverlibrary.d.ts and fix gulpfile 2018-01-17 11:06:09 -08:00
uniqueiniquity
543b48d031 Add test for file path in tsconfig 2018-01-17 10:58:25 -08:00
Daniel
2ca688a87d Remove the colon from the message in tsconfig.json (#21174)
* Add additional diagnostic message for tsconfig.json

* Add a way to override description for tsconfig.json

* Modify reference tsconfig.json in tests

* Don't have to differentiate cmdline and tsconfig.json description

This reverts commit efe57733cac305533c61c7bea3d51b302bbb4d19 and 94f9e67a247f2d73ddff6935083f76812efd2a21.

* Remove colon from diagnostic message code 6079

* Remove colon from localized messages code 6079

* Revert "Remove colon from localized messages code 6079"

Not changing files on src/loc because they are managed using automated tools.

This reverts commit e91f52348e17bf829db2418020c4281203d03e05.
2018-01-17 09:42:40 -08:00
Andy
be607bd28f
getStringLiteralCompletionEntries: switch on parent.type (#21169)
* getStringLiteralCompletionEntries: switch on parent.type

* Use a 'default' case and reduce findPrecedingToken calls

* fromType -> fromContextualType
2018-01-17 07:33:03 -08:00
Mohamed Hegazy
964565e069 Update authors for release 2.7 2018-01-16 23:31:46 -08:00
Ron Buckton
c4fddba0a9 Remove duplicate implementations 2018-01-16 17:11:32 -08:00
uniqueiniquity
5320ce2552 Revert path normalization in favor of checking for backslash 2018-01-16 17:04:14 -08:00
Ron Buckton
7a89c963b0
Merge pull request #21217 from Microsoft/fix20146
Symbol-named properties do not need to align with string indexer type
2018-01-16 17:01:27 -08:00
Ron Buckton
dcc5c32abf
Merge pull request #21216 from Microsoft/fix19103
Fix incorrect parenthesization logic for conditional expression branches
2018-01-16 17:00:55 -08:00
Ron Buckton
4aca0c8121 Fix destructuring assignment when assignment target is RHS 2018-01-16 16:58:56 -08:00
Ron Buckton
cd525fb6de
Merge pull request #21206 from Microsoft/fix20744
Fix temp variable emit for names used in nested classes
2018-01-16 16:00:24 -08:00