Nathan Shively-Sanders
6a175321bf
Address comments: simplify, dedupe and clean up
2017-05-05 15:09:54 -07:00
Arthur Ozga
818bfdcd88
accessibility check
2017-05-05 15:08:02 -07:00
Arthur Ozga
a1d2049c29
convert type format flags
2017-05-05 14:48:20 -07:00
Arthur Ozga
b8bb0c22f3
emit type parameter's default
2017-05-05 14:47:57 -07:00
Nathan Shively-Sanders
b39c319f0c
Fix lint
2017-05-05 13:48:45 -07:00
Arthur Ozga
a5bef216ae
Use symbolToName instead of copying
2017-05-05 13:47:51 -07:00
Nathan Shively-Sanders
573040f0cf
Convert Declaration to union, not type hierarchy
2017-05-05 13:47:28 -07:00
Arthur Ozga
d2bda47e80
fix inTypeAlias logic
2017-05-05 12:39:47 -07:00
Sheetal Nandi
fcb0f46178
Tune the completion list for static and private modifiers
...
Do not show inherited members in completion for when writing private member
Show only static inherited members when writing static member
2017-05-05 11:30:32 -07:00
Sheetal Nandi
37a2cddabc
Give the class element completion on typing keywords like public, private, readonly
...
Also when name of the function is location, make sure we are actually looking at the same symbol before using the declaration to get signature to display
2017-05-05 11:30:32 -07:00
Sheetal Nandi
b3d793608d
Completion list for a class extending another class should contain members from base class
...
Handles #7158
2017-05-05 11:30:32 -07:00
Arthur Ozga
1774c67afa
parens and this param for function type
2017-05-05 11:00:54 -07:00
Mohamed Hegazy
d483df94ef
Merge pull request #15600 from mjbvz/log-when-types-registry-is-updated
...
Add Log for When Typings Installer Finishes Updating the Types Registry
2017-05-05 10:43:51 -07:00
Andy Hanson
d36175b1e8
Remove some redundant code in createJsxAttributesTypeFromAttributesProperty
2017-05-05 08:51:18 -07:00
Nathan Shively-Sanders
4303a294f9
Merge pull request #15537 from Microsoft/emit-declaration-of-class-extending-intersection
...
Emit declaration of class extending intersection
2017-05-05 08:32:56 -07:00
Andy
1511c2eda7
Merge pull request #15593 from Microsoft/jsdoctagnames
...
Deduplicate jsDocTagNames and sort alphabetically
2017-05-05 07:24:12 -07:00
Yui T
fec3dc215a
Address PR
2017-05-04 22:16:23 -07:00
Matt Bierner
e44d419c90
Add Log for When Typings Installer Finishes Updating the Types Registry
...
**Bug**
While investigating #15301 , I was confused by the typing installer's log `Updating types-registry npm package...`. This was often the last line of the log file, leading me to believe that the types-registry update was still ongoing
**Fix**
Add an extra log for when the type-registry update completes successfully
2017-05-04 20:04:46 -07:00
Kanchalai Tanglertsampan
f619d5add4
Allow excess property in spread attributes but also check if any explicitly specified attributes are correct
2017-05-04 17:12:39 -07:00
Nathan Shively-Sanders
efe502e609
Address PR comments
2017-05-04 17:04:37 -07:00
Nathan Shively-Sanders
d35f6c3581
getNameOfDeclaration uniformly, including JS decls
...
JS-style assignment declarations have a name, but it's not stored on the
name property of the BinaryExpression. This commit adds
`getNameOfDeclaration` to uniformly get the name of a declaration.
It also reworks the declaration of `Declaration` so that accessing
`name` is an error unless the type does *not* include
BinaryExpression.
2017-05-04 16:12:54 -07:00
Arthur Ozga
384d54603f
Basic parens handling and stubbed TypeFormatFlags
2017-05-04 15:27:50 -07:00
Sheetal Nandi
96aca4c7d0
Merge pull request #13540 from Microsoft/metadataReferences
...
Mark as referenced aliases in Union that will get emitted as part of decorator metadata
2017-05-04 15:04:13 -07:00
Yui T
ae06e12238
Wip-fixing spread type
2017-05-04 14:39:51 -07:00
Andy Hanson
7dddcb816f
Deduplicate jsDocTagNames and sort alphabetically
2017-05-04 14:16:09 -07:00
Andy
7fe1aba82a
Merge pull request #15557 from Microsoft/unused-type-parameter
...
Mark type arguments as used even if used in an invalid way
2017-05-04 14:15:16 -07:00
Ron Buckton
500dd16bc1
Merge pull request #15590 from Microsoft/fix15471
...
Add check for tslib __await helper
2017-05-04 13:59:54 -07:00
Ron Buckton
cbeb11eabf
Add check for tslib __await helper
2017-05-04 13:13:10 -07:00
Nathan Shively-Sanders
d2bdfbbf0a
Merge pull request #15586 from Microsoft/fix-index-constraint-check-for-js-class-exprs
...
Add Javascript declarations to index constraint check error reporting
2017-05-04 12:55:55 -07:00
Andy Hanson
398d3aaf6c
Symbol table for homomorphic mapped type: Don't needlessly create twice
2017-05-04 12:45:15 -07:00
Mohamed Hegazy
d9b459bc3d
Merge pull request #15490 from SaschaNaz/allowArguments
...
Allow use of "arguments" on ambient context
2017-05-04 12:27:17 -07:00
Ron Buckton
e642691526
Merge pull request #15521 from Microsoft/fix15471
...
Fix over agressive async delegation
2017-05-04 11:30:26 -07:00
Anders Hejlsberg
4123068f19
Only get apparent type when constraint includes nullable types
2017-05-04 10:20:04 -07:00
Kanchalai Tanglertsampan
1b7d3bfa07
Merge branch 'master' into master-dynamicImport
2017-05-04 10:14:32 -07:00
Nathan Shively-Sanders
49fd1ad80b
Add JS declaration to index constraint check error reporting
...
Now Javascript-style declarations like `this.foo = "bar"` are handled
correctly.
2017-05-04 10:11:25 -07:00
Andy Hanson
8d8c4c2990
Reuse code from getTypeReferenceType
2017-05-04 08:42:56 -07:00
Anders Hejlsberg
3d069f7a54
New behavior only for type variables with nullable constraints
2017-05-03 21:28:03 -07:00
Nathan Shively-Sanders
9eaf40bded
Merge branch 'master' into spelling-correction
2017-05-03 15:34:32 -07:00
Nathan Shively-Sanders
0c10098c66
Fix case of suggestion blacklist.
...
It should be all lowercase since candidates have been lowercased by the
point the blacklist is checked.
2017-05-03 15:28:08 -07:00
Kanchalai Tanglertsampan
1e806cea01
For React Component class, we fill in missing type parameter and instantiate the constructor signature with the new type arguments.
2017-05-03 15:15:47 -07:00
Anders Hejlsberg
34481640c5
Obtain apparent type before narrowing type variables
2017-05-03 14:52:28 -07:00
Nathan Shively-Sanders
5a7e967628
Blacklist some built-ins and improve max cutoff
...
The maximum distance cutoff was being checked after the close-enough
early exit. Now it's checked before.
Note that `null` doesn't show up in the globals list, so it's not part
of the blacklist either.
2017-05-03 14:48:23 -07:00
Arthur Ozga
7282b9f0ce
make internal
2017-05-03 14:12:24 -07:00
Nathan Shively-Sanders
2a7398b12a
Include primitives in type-as-value error message
...
Previously, you would get the generic message when writing incorrect
code like `let y = number`. "Cannot find name 'number'". Now the message
says "'number' is a type but is used a value here."
Fixes #15565
2017-05-03 14:04:09 -07:00
Yui T
1125657210
Don't stop checking other attributes even though we see spread type. This is so that things are correctly marked as reference and type-checked
2017-05-03 13:42:38 -07:00
Arthur Ozga
0b68b934ef
respond to comments
2017-05-03 13:30:53 -07:00
Arthur Ozga
5eff8c206b
revert core changes
2017-05-03 13:29:24 -07:00
Arthur Ozga
d38ee1eaf7
restore startsWith
2017-05-03 13:26:24 -07:00
Arthur Ozga
69e7841cda
revert noop change
2017-05-03 13:22:01 -07:00
Arthur Ozga
5ce32ccbe3
factor out helpers + cleanup startsWith and friends
2017-05-03 13:13:28 -07:00
