microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-24 20:44:53 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Skip invalid completion check immediately after newline (#55061)

Browse Source 
Co-authored-by: Isabel Duan <isabelduan@microsoft.com>
This commit is contained in:
Sg
2023-11-21 05:18:06 +08:00
committed by GitHub
parent 77a2f64810
commit ffc21e5752
3 changed files with 54 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/services/completions.ts
View File

@@ -4666,6 +4666,10 @@ function getCompletionData(
return undefined;
}
function isInDifferentLineThanContextToken(contextToken: Node, position: number): boolean {
return sourceFile.getLineEndOfPosition(contextToken.getEnd()) < position;
}
/**
* @returns true if we are certain that the currently edited location must define a new location; false otherwise.
*/
@@ -4733,7 +4737,7 @@ function getCompletionData(
case SyntaxKind.SetKeyword:
return !isFromObjectTypeDeclaration(contextToken);
case SyntaxKind.Identifier:
case SyntaxKind.Identifier: {
if (containingNodeKind === SyntaxKind.ImportSpecifier &&
contextToken === (parent as ImportSpecifier).name &&
(contextToken as Identifier).text === "type"
@@ -4741,7 +4745,16 @@ function getCompletionData(
// import { type | }
return false;
}
const ancestorVariableDeclaration = findAncestor(
contextToken.parent, isVariableDeclaration);
if (ancestorVariableDeclaration
&& isInDifferentLineThanContextToken(contextToken, position)) {
// let a
// |
return false;
}
break;
}
case SyntaxKind.ClassKeyword:
case SyntaxKind.EnumKeyword: