From 6cdbc6cad0243af02f8a70d4f132c659923814c2 Mon Sep 17 00:00:00 2001 From: Ryan Cavanaugh Date: Tue, 1 Mar 2016 13:47:29 -0800 Subject: [PATCH] Show aliases (e.g. imports) in JSX tag completion positions Fixes #4577 --- src/services/services.ts | 2 +- tests/cases/fourslash/tsxCompletion11.ts | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/tsxCompletion11.ts diff --git a/src/services/services.ts b/src/services/services.ts index 65a6bd1362c..c297d33fdb4 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -3134,7 +3134,7 @@ namespace ts { else if (isRightOfOpenTag) { const tagSymbols = typeChecker.getJsxIntrinsicTagNames(); if (tryGetGlobalSymbols()) { - symbols = tagSymbols.concat(symbols.filter(s => !!(s.flags & SymbolFlags.Value))); + symbols = tagSymbols.concat(symbols.filter(s => !!(s.flags & (SymbolFlags.Value | SymbolFlags.Alias)))); } else { symbols = tagSymbols; diff --git a/tests/cases/fourslash/tsxCompletion11.ts b/tests/cases/fourslash/tsxCompletion11.ts new file mode 100644 index 00000000000..5d9c869a9b6 --- /dev/null +++ b/tests/cases/fourslash/tsxCompletion11.ts @@ -0,0 +1,14 @@ +/// + +//@module: commonjs +//@jsx: preserve + +//@Filename: exporter.tsx +//// export class Thing { } + +//@Filename: file.tsx +//// import {Thing} from './exporter'; +//// var x1 =