From fd71eb2c856ceb5aa2e36cdd161641cd8d2d3fc3 Mon Sep 17 00:00:00 2001 From: jeffy-g Date: Tue, 12 May 2020 05:02:20 +0900 Subject: [PATCH] fix broken regex on "src/services/completions.ts#getCompletionData" (#37546) * fix broken regex on src/services/completions.ts#840 * update forslash test breaking changes fourslash test Temporarily retain the before fix code for easy comparison * regex * fourslash test (Temporary code * regex: more restrictive in terms of jsdoc format fourslash test * regex: max indent restriction * achieved goal by partial match strategy (probably * cleanup * apply requested changes * Change to a version with minimal modifications --- src/services/completions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/completions.ts b/src/services/completions.ts index a1e98a03d87..a3845bf3ece 100644 --- a/src/services/completions.ts +++ b/src/services/completions.ts @@ -875,7 +875,7 @@ namespace ts.Completions { // * |c| // */ const lineStart = getLineStartPositionForPosition(position, sourceFile); - if (!(sourceFile.text.substring(lineStart, position).match(/[^\*|\s|(/\*\*)]/))) { + if (!/[^\*|\s(/)]/.test(sourceFile.text.substring(lineStart, position))) { return { kind: CompletionDataKind.JsDocTag }; } }