From fd5a04cb14b22b1ffcc557659960db5c581943ad Mon Sep 17 00:00:00 2001 From: Paul van Brenk Date: Thu, 30 Apr 2015 15:01:37 -0700 Subject: [PATCH] this fixes No builder in right-hand side of object binding pattern element #2693 and adds tests --- src/services/services.ts | 3 +++ .../fourslash/completionListNewIdentifierBindingElement.ts | 6 ++++++ 2 files changed, 9 insertions(+) create mode 100644 tests/cases/fourslash/completionListNewIdentifierBindingElement.ts diff --git a/src/services/services.ts b/src/services/services.ts index c42fcf79947..06da4859274 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -3011,6 +3011,9 @@ module ts { case SyntaxKind.TemplateMiddle: return containingNodeKind === SyntaxKind.TemplateSpan; // `aa ${10} dd ${| + case SyntaxKind.ColonToken: + return containingNodeKind === SyntaxKind.BindingElement; // var {x :html| + case SyntaxKind.PublicKeyword: case SyntaxKind.PrivateKeyword: case SyntaxKind.ProtectedKeyword: diff --git a/tests/cases/fourslash/completionListNewIdentifierBindingElement.ts b/tests/cases/fourslash/completionListNewIdentifierBindingElement.ts new file mode 100644 index 00000000000..3d1c17e0efd --- /dev/null +++ b/tests/cases/fourslash/completionListNewIdentifierBindingElement.ts @@ -0,0 +1,6 @@ +/// + +////var { x:html/*1*/ + +goTo.marker("1"); +verify.completionListAllowsNewIdentifier(); \ No newline at end of file