From fc03982b73ebaabfdfd2ef25bc1538e86a635b7b Mon Sep 17 00:00:00 2001 From: Wenlu Wang Date: Fri, 25 Sep 2020 03:48:29 +0800 Subject: [PATCH] Add missing visitor of template literal type (#40738) * Add missing visitor of template literal type * make linter happy --- src/compiler/factory/nodeTests.ts | 4 ++++ src/compiler/visitorPublic.ts | 10 ++++++++++ tests/baselines/reference/api/tsserverlibrary.d.ts | 1 + tests/baselines/reference/api/typescript.d.ts | 1 + 4 files changed, 16 insertions(+) diff --git a/src/compiler/factory/nodeTests.ts b/src/compiler/factory/nodeTests.ts index b7da2127f2a..26030947175 100644 --- a/src/compiler/factory/nodeTests.ts +++ b/src/compiler/factory/nodeTests.ts @@ -233,6 +233,10 @@ namespace ts { return node.kind === SyntaxKind.ImportType; } + export function isTemplateLiteralTypeSpan(node: Node): node is TemplateLiteralTypeSpan { + return node.kind === SyntaxKind.TemplateLiteralTypeSpan; + } + // Binding patterns export function isObjectBindingPattern(node: Node): node is ObjectBindingPattern { diff --git a/src/compiler/visitorPublic.ts b/src/compiler/visitorPublic.ts index 899936e5962..8a06e110552 100644 --- a/src/compiler/visitorPublic.ts +++ b/src/compiler/visitorPublic.ts @@ -573,6 +573,16 @@ namespace ts { return factory.updateLiteralTypeNode(node, nodeVisitor((node).literal, visitor, isExpression)); + case SyntaxKind.TemplateLiteralType: + return factory.updateTemplateLiteralType(node, + nodeVisitor((node).head, visitor, isTemplateHead), + nodesVisitor((node).templateSpans, visitor, isTemplateLiteralTypeSpan)); + + case SyntaxKind.TemplateLiteralTypeSpan: + return factory.updateTemplateLiteralTypeSpan(node, + nodeVisitor((node).type, visitor, isTypeNode), + nodeVisitor((node).literal, visitor, isTemplateMiddleOrTemplateTail)); + // Binding patterns case SyntaxKind.ObjectBindingPattern: return factory.updateObjectBindingPattern(node, diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts index 2b5ca8d1f18..ad725a4faee 100644 --- a/tests/baselines/reference/api/tsserverlibrary.d.ts +++ b/tests/baselines/reference/api/tsserverlibrary.d.ts @@ -4368,6 +4368,7 @@ declare namespace ts { function isMappedTypeNode(node: Node): node is MappedTypeNode; function isLiteralTypeNode(node: Node): node is LiteralTypeNode; function isImportTypeNode(node: Node): node is ImportTypeNode; + function isTemplateLiteralTypeSpan(node: Node): node is TemplateLiteralTypeSpan; function isObjectBindingPattern(node: Node): node is ObjectBindingPattern; function isArrayBindingPattern(node: Node): node is ArrayBindingPattern; function isBindingElement(node: Node): node is BindingElement; diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts index 0df67772e6e..220231cfa94 100644 --- a/tests/baselines/reference/api/typescript.d.ts +++ b/tests/baselines/reference/api/typescript.d.ts @@ -4368,6 +4368,7 @@ declare namespace ts { function isMappedTypeNode(node: Node): node is MappedTypeNode; function isLiteralTypeNode(node: Node): node is LiteralTypeNode; function isImportTypeNode(node: Node): node is ImportTypeNode; + function isTemplateLiteralTypeSpan(node: Node): node is TemplateLiteralTypeSpan; function isObjectBindingPattern(node: Node): node is ObjectBindingPattern; function isArrayBindingPattern(node: Node): node is ArrayBindingPattern; function isBindingElement(node: Node): node is BindingElement;