From f94025d855581f4fc94d7ca895fc2c227614205a Mon Sep 17 00:00:00 2001
From: Andy Hanson <anhans@microsoft.com>
Date: Fri, 1 Jul 2016 13:34:15 -0700
Subject: [PATCH] Improve web tests

* Provide a favicon so chrome doesn't block waiting for one
* Provide accurate content type so chrome doesn't warn
---
 tests/webTestResults.html       |  13 +++++++------
 tests/webTestServer.ts          |  26 +++++++++++++++++---------
 tests/webhost/favicon-32x32.png | Bin 0 -> 800 bytes
 3 files changed, 24 insertions(+), 15 deletions(-)
 create mode 100644 tests/webhost/favicon-32x32.png
diff --git a/tests/webTestResults.html b/tests/webTestResults.html
index 2993681934e..9c403248f94 100644
--- a/tests/webTestResults.html
+++ b/tests/webTestResults.html
@@ -3,22 +3,23 @@
   <meta charset="utf-8">
   <title>Mocha Tests</title>
   <link rel="stylesheet" href="../node_modules/mocha/mocha.css" />
+  <link rel="icon" href="./webhost/favicon-32x32.png"/>
 </head>
 <body>
-  <div id='setup'>   
+  <div id='setup'>
     <div>
-      <button id='selectCompilerBtn' onclick='location.href="http://localhost:8888/tests/webTestResults.html?grep=compiler"'>Select Compiler Tests</button>  
-      <button id='selectFourslashBtn' onclick='location.href="http://localhost:8888/tests/webTestResults.html?grep=fourslash"'>Select Fourslash Tests</button>  
+      <button id='selectCompilerBtn' onclick='location.href="http://localhost:8888/tests/webTestResults.html?grep=compiler"'>Select Compiler Tests</button>
+      <button id='selectFourslashBtn' onclick='location.href="http://localhost:8888/tests/webTestResults.html?grep=fourslash"'>Select Fourslash Tests</button>
     </div>
-    <button id='runTestBtn' onclick='runTests()'>Run Tests</button>  
+    <button id='runTestBtn' onclick='runTests()'>Run Tests</button>
   </div>
-  
+
   <div id="mocha"></div>
   <script src="http://ajax.aspnetcdn.com/ajax/jQuery/jquery-2.1.0.js"></script>
   <script src="../node_modules/mocha/mocha.js"></script>
   <script>mocha.setup('bdd')</script>
   <script src="../built/local/bundle.js"></script>
-  
+
   <script>
     // mocha is going to call this on every test result and make the results page unusable for a long
     // time after the tests are already done, doesn't seem necessary
diff --git a/tests/webTestServer.ts b/tests/webTestServer.ts
index 9d28b4592ff..b79c464ab4e 100644
--- a/tests/webTestServer.ts
+++ b/tests/webTestServer.ts
@@ -111,7 +111,7 @@ function writeFile(path: string, data: any, opts: { recursive: boolean }) {
 
 /// Request Handling ///
 
-function handleResolutionRequest(filePath: string, res: http.ServerResponse) {    
+function handleResolutionRequest(filePath: string, res: http.ServerResponse) {
     var resolvedPath = path.resolve(filePath, '');
     resolvedPath = resolvedPath.substring(resolvedPath.indexOf('tests'));
     resolvedPath = switchToForwardSlashes(resolvedPath);
@@ -202,14 +202,13 @@ function handleRequestOperation(req: http.ServerRequest, res: http.ServerRespons
             break;
         case RequestType.GetFile:
             fs.readFile(reqPath, function (err, file) {
-                var ext = reqPath.substr(reqPath.lastIndexOf('.'));
-                var contentType = 'binary';
-                if (ext === '.js') contentType = 'text/javascript'
-                else if (ext === '.css') contentType = 'text/javascript'
-                else if (ext === '.html') contentType = 'text/html'
-                err
-                ? send('fail', res, err.message, contentType)
-                : send('success', res, (<any>file), contentType);
+                const contentType = contentTypeForExtension(path.extname(reqPath));
+                if (err) {
+                    send('fail', res, err.message, contentType);
+                }
+                else {
+                    send('success', res, <any>file, contentType);
+                }
             });
             break;
         case RequestType.ResolveFile:
@@ -249,6 +248,15 @@ function handleRequestOperation(req: http.ServerRequest, res: http.ServerRespons
             send('unknown', res, null);
             break;
     }
+
+    function contentTypeForExtension(ext: string) {
+        switch (ext) {
+            case '.js': return 'text/javascript';
+            case '.css': return 'text/css';
+            case '.html': return 'text/html';
+            default: return 'binary';
+        }
+    }
 }
 
 console.log("Static file server running at\n  => http://localhost:" + port + "/\nCTRL + C to shutdown");
diff --git a/tests/webhost/favicon-32x32.png b/tests/webhost/favicon-32x32.png
new file mode 100644
index 0000000000000000000000000000000000000000..efbce163f929bbd4d551f93940a6d9187f9cca1c
GIT binary patch
literal 800
zcmV+*1K<3KP)<h;3K|Lk000e1NJLTq001BW001Be0{{R3M5Kzw0004)P)t-s0Cd3s
zbHM;}zyx-}9D~Rpg~=d>$rXRb0CK<vcfuZo$P#|V8-vKk;PK<|_~GyP<?;EH#pMBX
z!4Q1KVyW4$)a=yf^x*FI-tG6#<@2Y{>M@VaABD)^?)d-z|EA9A8G*;C(CYjB{$Q!t
z8iL2X+V9ut_0{P0*y{E6`u*zk`qt?6+3NO;z~h9x;r{;r-|hFi+U~vE@7wJ5`uzT3
zsn`Q`!W4hT7J$YghRMt0@`=CV6Mn|b<MSqo$_IGE2zkRDgvej0*gcid4SK|WxZePA
zz#W6gh`r(faK8<E#D2Np(dP8s?e|Td)CP9K0d>KV!{qSy`=ib2LYUDAcf%ux$;008
z@%a3r%;+eI${~iym&fMp^!h1^%LR7AHj&Pg#O3Pq`k2S&0(HUzbiqTI(c0_w)93UR
zfX0Ts;ot7}7=g#E((7ic+9im}x!LZ{<n!3-_Wl0;-0b$c+U|+I;unF(*6H=L*6j;=
z#IDopZ?N12cfwbr*3IPe-R$?&==HSL?Q5>v0(HR;e8mxc#Rhl724&}%0003)Nkl<Z
zILqylRZ~J?5QcX@Kt4rKu@LdKyD>Oo0CsnG7ns=H{%tS7qm0LUFMO_cW}n%acXx^Y
z`E#&PVIm@C=I?!--tbA3kyu6>WArB7m%_1TOI(=v1Z!eaa!RT#&7Lk)!I1%#%&hF3
zP?alHAuqq6u&5X)DJ(53uK+5ms+~2pb*e!1E=6f@1C33JVrT}cTRdK0Yn%9%f<?O-
z=;&nGRRwhSFtM~oChau?eUjMK4-5<r$sel-3p6|eV03JJLi{4|<P-o*&&&#KfyCVW
z0sy!dg|<LqX?bN8z}mXDz(jIma|_tsVJ*R<NG9sp1^hmt6*I86@AG;N4uK;RYYNA~
z6X&U|5;)Ud)cHl|RKZJq!~nXwwpeZ?(e0i6{=xtF^lXgm(@VhNcqJl|x;MSg_%2!F
e?N~isxcUH(8alIFAJ@(R0000<MNUMnLSTZ3slTWI

literal 0
HcmV?d00001

