From f8228e1544dfe688c0652470d7d684d75dcfdb01 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Mon, 4 Aug 2014 13:37:17 -0700 Subject: [PATCH] Change variabel names: * documentsByName to sourceFilesByName * getSymbolOfIdentifierLikeNode to getSymbolInfo --- src/compiler/checker.ts | 4 ++-- src/compiler/types.ts | 2 +- src/services/services.ts | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 6603f93b493..694b251beb5 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -88,7 +88,7 @@ module ts { getReturnTypeOfSignature: getReturnTypeOfSignature, resolveEntityName: resolveEntityName, getSymbolsInScope: getSymbolsInScope, - getSymbolOfIdentifierLikeNode: getSymbolOfIdentifierLikeNode, + getSymbolInfo: getSymbolInfo, getTypeOfExpression: getTypeOfExpression, typeToString: typeToString, symbolToString: symbolToString, @@ -6437,7 +6437,7 @@ module ts { } } - function getSymbolOfIdentifierLikeNode(node: Node) { + function getSymbolInfo(node: Node) { switch (node.kind) { case SyntaxKind.Identifier: return getSymbolOfIdentifier(node); diff --git a/src/compiler/types.ts b/src/compiler/types.ts index 725e6d9b110..e967c58f618 100644 --- a/src/compiler/types.ts +++ b/src/compiler/types.ts @@ -605,7 +605,7 @@ module ts { getReturnTypeOfSignature(signature: Signature): Type; resolveEntityName(location: Node, name: EntityName, meaning: SymbolFlags): Symbol; getSymbolsInScope(location: Node, meaning: SymbolFlags): Symbol[]; - getSymbolOfIdentifierLikeNode(node: Node): Symbol; + getSymbolInfo(node: Node): Symbol; getTypeOfExpression(node: Expression, contextualType?: Type, contextualMapper?: TypeMapper): Type; typeToString(type: Type, enclosingDeclaration?: Node, flags?: TypeFormatFlags): string; symbolToString(symbol: Symbol, enclosingDeclaration?: Node, meaning?: SymbolFlags): string; diff --git a/src/services/services.ts b/src/services/services.ts index 57b8781d051..f2c99209169 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -1221,7 +1221,7 @@ module ts { var program: Program; var typeChecker: TypeChecker; var useCaseSensitivefilenames = false; - var documentsByName: Map = {}; + var sourceFilesByName: Map = {}; var documentRegistry = documentRegistry; var cancellationToken = new CancellationTokenObject(host.getCancellationToken()); var activeCompletionSession: CompletionSession; // The current active completion session, used to get the completion entry details @@ -1232,7 +1232,7 @@ module ts { } function getSourceFile(filename: string): SourceFile { - return lookUp(documentsByName, filename); + return lookUp(sourceFilesByName, filename); } function createCompilerHost(): CompilerHost { @@ -1291,7 +1291,7 @@ module ts { var filename = oldSourceFiles[i].filename; if (!hostCache.contains(filename) || changesInCompilationSettingsAffectSyntax) { documentRegistry.releaseDocument(filename, oldSettings); - delete documentsByName[filename]; + delete sourceFilesByName[filename]; } } } @@ -1335,7 +1335,7 @@ module ts { } // Remeber the new sourceFile - documentsByName[filename] = sourceFile; + sourceFilesByName[filename] = sourceFile; } // Now create a new compiler @@ -1810,7 +1810,7 @@ module ts { var node = getNodeAtPosition(sourceFile.getSourceFile(), position); if (!node) return undefined; - var symbol = typeChecker.getSymbolOfIdentifierLikeNode(node); + var symbol = typeChecker.getSymbolInfo(node); var type = symbol && typeChecker.getTypeOfSymbol(symbol); if (type) { return { @@ -1962,7 +1962,7 @@ module ts { return undefined; } - var symbol = typeChecker.getSymbolOfIdentifierLikeNode(node); + var symbol = typeChecker.getSymbolInfo(node); // Could not find a symbol e.g. node is string or number keyword, // or the symbol was an internal symbol and does not have a declaration e.g. undefined symbol