From f7f50073d3e8166b04647617e94f438e69db5595 Mon Sep 17 00:00:00 2001
From: Yui <yuit@users.noreply.github.com>
Date: Tue, 16 Aug 2016 08:47:21 -0700
Subject: [PATCH] Fix 10625: JSX Not validating when index signature is present
  (#10352)

* Check for type of property declaration before using index signature

* Add tests and baselines

* fix linting error
---
 src/compiler/checker.ts                       |  7 ++-
 .../tsxAttributeResolution14.errors.txt       | 38 +++++++++++++++
 .../reference/tsxAttributeResolution14.js     | 47 +++++++++++++++++++
 .../jsx/tsxAttributeResolution14.tsx          | 32 +++++++++++++
 4 files changed, 120 insertions(+), 4 deletions(-)
 create mode 100644 tests/baselines/reference/tsxAttributeResolution14.errors.txt
 create mode 100644 tests/baselines/reference/tsxAttributeResolution14.js
 create mode 100644 tests/cases/conformance/jsx/tsxAttributeResolution14.tsx

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
index 984cedbf5ad..25a35c307f4 100644
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -10140,10 +10140,9 @@ namespace ts {
                 const correspondingPropSymbol = getPropertyOfType(elementAttributesType, node.name.text);
                 correspondingPropType = correspondingPropSymbol && getTypeOfSymbol(correspondingPropSymbol);
                 if (isUnhyphenatedJsxName(node.name.text)) {
-                    // Maybe there's a string indexer?
-                    const indexerType = getIndexTypeOfType(elementAttributesType, IndexKind.String);
-                    if (indexerType) {
-                        correspondingPropType = indexerType;
+                    const attributeType = getTypeOfPropertyOfType(elementAttributesType, getTextOfPropertyName(node.name)) || getIndexTypeOfType(elementAttributesType, IndexKind.String);
+                    if (attributeType) {
+                        correspondingPropType = attributeType;
                     }
                     else {
                         // If there's no corresponding property with this name, error
diff --git a/tests/baselines/reference/tsxAttributeResolution14.errors.txt b/tests/baselines/reference/tsxAttributeResolution14.errors.txt
new file mode 100644
index 00000000000..81d42e49059
--- /dev/null
+++ b/tests/baselines/reference/tsxAttributeResolution14.errors.txt
@@ -0,0 +1,38 @@
+tests/cases/conformance/jsx/file.tsx(14,28): error TS2322: Type 'number' is not assignable to type 'string'.
+tests/cases/conformance/jsx/file.tsx(16,28): error TS2322: Type 'boolean' is not assignable to type 'string | number'.
+
+
+==== tests/cases/conformance/jsx/react.d.ts (0 errors) ====
+    
+    declare module JSX {
+    	interface Element { }
+    	interface IntrinsicElements {
+            div: any;
+    	}
+        interface ElementAttributesProperty { prop: any }
+    }
+    
+==== tests/cases/conformance/jsx/file.tsx (2 errors) ====
+    
+    interface IProps {
+      primaryText: string,
+      [propName: string]: string | number
+    }
+    
+    function VerticalNavMenuItem(prop: IProps) {
+      return <div>props.primaryText</div>
+    }
+    
+    function VerticalNav() {
+      return (
+        <div>
+          <VerticalNavMenuItem primaryText={2} />  // error
+                               ~~~~~~~~~~~~~~~
+!!! error TS2322: Type 'number' is not assignable to type 'string'.
+          <VerticalNavMenuItem justRandomProp={2} primaryText={"hello"} />  // ok
+          <VerticalNavMenuItem justRandomProp1={true} primaryText={"hello"} />  // error
+                               ~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2322: Type 'boolean' is not assignable to type 'string | number'.
+        </div>
+      )
+    } 
\ No newline at end of file
diff --git a/tests/baselines/reference/tsxAttributeResolution14.js b/tests/baselines/reference/tsxAttributeResolution14.js
new file mode 100644
index 00000000000..d920179458c
--- /dev/null
+++ b/tests/baselines/reference/tsxAttributeResolution14.js
@@ -0,0 +1,47 @@
+//// [tests/cases/conformance/jsx/tsxAttributeResolution14.tsx] ////
+
+//// [react.d.ts]
+
+declare module JSX {
+	interface Element { }
+	interface IntrinsicElements {
+        div: any;
+	}
+    interface ElementAttributesProperty { prop: any }
+}
+
+//// [file.tsx]
+
+interface IProps {
+  primaryText: string,
+  [propName: string]: string | number
+}
+
+function VerticalNavMenuItem(prop: IProps) {
+  return <div>props.primaryText</div>
+}
+
+function VerticalNav() {
+  return (
+    <div>
+      <VerticalNavMenuItem primaryText={2} />  // error
+      <VerticalNavMenuItem justRandomProp={2} primaryText={"hello"} />  // ok
+      <VerticalNavMenuItem justRandomProp1={true} primaryText={"hello"} />  // error
+    </div>
+  )
+} 
+
+//// [file.jsx]
+function VerticalNavMenuItem(prop) {
+    return <div>props.primaryText</div>;
+}
+function VerticalNav() {
+    return (<div>
+      <VerticalNavMenuItem primaryText={2}/> // error
+      // error
+      <VerticalNavMenuItem justRandomProp={2} primaryText={"hello"}/> // ok
+      // ok
+      <VerticalNavMenuItem justRandomProp1={true} primaryText={"hello"}/> // error
+      // error
+    </div>);
+}
diff --git a/tests/cases/conformance/jsx/tsxAttributeResolution14.tsx b/tests/cases/conformance/jsx/tsxAttributeResolution14.tsx
new file mode 100644
index 00000000000..1e4418e7fba
--- /dev/null
+++ b/tests/cases/conformance/jsx/tsxAttributeResolution14.tsx
@@ -0,0 +1,32 @@
+//@jsx: preserve
+//@module: amd
+
+//@filename: react.d.ts
+declare module JSX {
+	interface Element { }
+	interface IntrinsicElements {
+        div: any;
+	}
+    interface ElementAttributesProperty { prop: any }
+}
+
+//@filename: file.tsx
+
+interface IProps {
+  primaryText: string,
+  [propName: string]: string | number
+}
+
+function VerticalNavMenuItem(prop: IProps) {
+  return <div>props.primaryText</div>
+}
+
+function VerticalNav() {
+  return (
+    <div>
+      <VerticalNavMenuItem primaryText={2} />  // error
+      <VerticalNavMenuItem justRandomProp={2} primaryText={"hello"} />  // ok
+      <VerticalNavMenuItem justRandomProp1={true} primaryText={"hello"} />  // error
+    </div>
+  )
+} 
\ No newline at end of file