microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-17 01:49:57 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(40901): skip checking custom arguments name in a constructor (#40912)

Browse Source
This commit is contained in:
Oleksandr T
2020-11-03 00:35:07 +02:00
committed by GitHub
parent 373b352333
commit f646ec87fc
57 changed files with 1862 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/compiler/checker.ts
View File

@@ -11709,7 +11709,7 @@ namespace ts {
if (!node) return false;
switch (node.kind) {
case SyntaxKind.Identifier:
return (<Identifier>node).escapedText === "arguments" && isExpressionNode(node);
return (<Identifier>node).escapedText === argumentsSymbol.escapedName && getResolvedSymbol(<Identifier>node) === argumentsSymbol;
case SyntaxKind.PropertyDeclaration:
case SyntaxKind.MethodDeclaration:
@@ -11718,6 +11718,10 @@ namespace ts {
return (<NamedDeclaration>node).name!.kind === SyntaxKind.ComputedPropertyName
&& traverse((<NamedDeclaration>node).name!);
case SyntaxKind.PropertyAccessExpression:
case SyntaxKind.ElementAccessExpression:
return traverse((<PropertyAccessExpression | ElementAccessExpression>node).expression);
default:
return !nodeStartsNewLexicalEnvironment(node) && !isPartOfTypeNode(node) && !!forEachChild(node, traverse);
}