Remove unnecessary diagnostics split on SourceFile.

2026-05-15 12:51:30 -05:00 · 2015-02-05 13:38:11 -08:00
parent f20fbb9726
commit ea4e3de91c
14 changed files with 13 additions and 78 deletions
--- a/tests/baselines/reference/APISample_compile.js
+++ b/tests/baselines/reference/APISample_compile.js
@@ -1407,7 +1407,6 @@ declare module "typescript" {
    function createNode(kind: SyntaxKind): Node;
    function forEachChild<T>(node: Node, cbNode: (node: Node) => T, cbNodeArray?: (nodes: Node[]) => T): T;
    function modifierToFlag(token: SyntaxKind): NodeFlags;
-    function getSyntacticDiagnostics(sourceFile: SourceFile): Diagnostic[];
    function updateSourceFile(sourceFile: SourceFile, newText: string, textChangeRange: TextChangeRange): SourceFile;
    function isEvalOrArgumentsIdentifier(node: Node): boolean;
    function createSourceFile(fileName: string, sourceText: string, languageVersion: ScriptTarget, setParentNodes?: boolean): SourceFile;
@@ -1473,7 +1472,6 @@ declare module "typescript" {
        getLineAndCharacterFromPosition(pos: number): LineAndCharacter;
        getLineStarts(): number[];
        getPositionFromLineAndCharacter(line: number, character: number): number;
-        getSyntacticDiagnostics(): Diagnostic[];
        update(newText: string, textChangeRange: TextChangeRange): SourceFile;
    }
    /**
--- a/tests/baselines/reference/APISample_compile.types
+++ b/tests/baselines/reference/APISample_compile.types
@@ -4493,12 +4493,6 @@ declare module "typescript" {

 >ResolvedType : ResolvedType
 >ObjectType : ObjectType
->UnionType : UnionType
-
-        members: SymbolTable;
-
->members : SymbolTable
->SymbolTable : SymbolTable
 >UnionType : UnionType

        members: SymbolTable;
@@ -4755,10 +4749,6 @@ declare module "typescript" {

        messageText: string | DiagnosticMessageChain;

->DiagnosticCategory : DiagnosticCategory
-
-        code: number;
-
 >messageText : string | DiagnosticMessageChain
 >DiagnosticMessageChain : DiagnosticMessageChain

--- a/tests/baselines/reference/APISample_linter.js
+++ b/tests/baselines/reference/APISample_linter.js
@@ -1439,7 +1439,6 @@ declare module "typescript" {
    function createNode(kind: SyntaxKind): Node;
    function forEachChild<T>(node: Node, cbNode: (node: Node) => T, cbNodeArray?: (nodes: Node[]) => T): T;
    function modifierToFlag(token: SyntaxKind): NodeFlags;
-    function getSyntacticDiagnostics(sourceFile: SourceFile): Diagnostic[];
    function updateSourceFile(sourceFile: SourceFile, newText: string, textChangeRange: TextChangeRange): SourceFile;
    function isEvalOrArgumentsIdentifier(node: Node): boolean;
    function createSourceFile(fileName: string, sourceText: string, languageVersion: ScriptTarget, setParentNodes?: boolean): SourceFile;
@@ -1505,7 +1504,6 @@ declare module "typescript" {
        getLineAndCharacterFromPosition(pos: number): LineAndCharacter;
        getLineStarts(): number[];
        getPositionFromLineAndCharacter(line: number, character: number): number;
-        getSyntacticDiagnostics(): Diagnostic[];
        update(newText: string, textChangeRange: TextChangeRange): SourceFile;
    }
    /**
--- a/tests/baselines/reference/APISample_linter.types
+++ b/tests/baselines/reference/APISample_linter.types
@@ -4640,12 +4640,6 @@ declare module "typescript" {

 >ResolvedType : ResolvedType
 >ObjectType : ObjectType
->UnionType : UnionType
-
-        members: SymbolTable;
-
->members : SymbolTable
->SymbolTable : SymbolTable
 >UnionType : UnionType

        members: SymbolTable;
@@ -4902,10 +4896,6 @@ declare module "typescript" {

        messageText: string | DiagnosticMessageChain;

->DiagnosticCategory : DiagnosticCategory
-
-        code: number;
-
 >messageText : string | DiagnosticMessageChain
 >DiagnosticMessageChain : DiagnosticMessageChain

--- a/tests/baselines/reference/APISample_transform.js
+++ b/tests/baselines/reference/APISample_transform.js
@@ -1440,7 +1440,6 @@ declare module "typescript" {
    function createNode(kind: SyntaxKind): Node;
    function forEachChild<T>(node: Node, cbNode: (node: Node) => T, cbNodeArray?: (nodes: Node[]) => T): T;
    function modifierToFlag(token: SyntaxKind): NodeFlags;
-    function getSyntacticDiagnostics(sourceFile: SourceFile): Diagnostic[];
    function updateSourceFile(sourceFile: SourceFile, newText: string, textChangeRange: TextChangeRange): SourceFile;
    function isEvalOrArgumentsIdentifier(node: Node): boolean;
    function createSourceFile(fileName: string, sourceText: string, languageVersion: ScriptTarget, setParentNodes?: boolean): SourceFile;
@@ -1506,7 +1505,6 @@ declare module "typescript" {
        getLineAndCharacterFromPosition(pos: number): LineAndCharacter;
        getLineStarts(): number[];
        getPositionFromLineAndCharacter(line: number, character: number): number;
-        getSyntacticDiagnostics(): Diagnostic[];
        update(newText: string, textChangeRange: TextChangeRange): SourceFile;
    }
    /**
--- a/tests/baselines/reference/APISample_transform.types
+++ b/tests/baselines/reference/APISample_transform.types
@@ -4592,12 +4592,6 @@ declare module "typescript" {

 >ResolvedType : ResolvedType
 >ObjectType : ObjectType
->UnionType : UnionType
-
-        members: SymbolTable;
-
->members : SymbolTable
->SymbolTable : SymbolTable
 >UnionType : UnionType

        members: SymbolTable;
@@ -4854,10 +4848,6 @@ declare module "typescript" {

        messageText: string | DiagnosticMessageChain;

->DiagnosticCategory : DiagnosticCategory
-
-        code: number;
-
 >messageText : string | DiagnosticMessageChain
 >DiagnosticMessageChain : DiagnosticMessageChain

--- a/tests/baselines/reference/APISample_watcher.js
+++ b/tests/baselines/reference/APISample_watcher.js
@@ -1477,7 +1477,6 @@ declare module "typescript" {
    function createNode(kind: SyntaxKind): Node;
    function forEachChild<T>(node: Node, cbNode: (node: Node) => T, cbNodeArray?: (nodes: Node[]) => T): T;
    function modifierToFlag(token: SyntaxKind): NodeFlags;
-    function getSyntacticDiagnostics(sourceFile: SourceFile): Diagnostic[];
    function updateSourceFile(sourceFile: SourceFile, newText: string, textChangeRange: TextChangeRange): SourceFile;
    function isEvalOrArgumentsIdentifier(node: Node): boolean;
    function createSourceFile(fileName: string, sourceText: string, languageVersion: ScriptTarget, setParentNodes?: boolean): SourceFile;
@@ -1543,7 +1542,6 @@ declare module "typescript" {
        getLineAndCharacterFromPosition(pos: number): LineAndCharacter;
        getLineStarts(): number[];
        getPositionFromLineAndCharacter(line: number, character: number): number;
-        getSyntacticDiagnostics(): Diagnostic[];
        update(newText: string, textChangeRange: TextChangeRange): SourceFile;
    }
    /**
--- a/tests/baselines/reference/APISample_watcher.types
+++ b/tests/baselines/reference/APISample_watcher.types
@@ -4766,12 +4766,6 @@ declare module "typescript" {

 >ResolvedType : ResolvedType
 >ObjectType : ObjectType
->UnionType : UnionType
-
-        members: SymbolTable;
-
->members : SymbolTable
->SymbolTable : SymbolTable
 >UnionType : UnionType

        members: SymbolTable;
@@ -5028,10 +5022,6 @@ declare module "typescript" {

        messageText: string | DiagnosticMessageChain;

->DiagnosticCategory : DiagnosticCategory
-
-        code: number;
-
 >messageText : string | DiagnosticMessageChain
 >DiagnosticMessageChain : DiagnosticMessageChain

--- a/tests/cases/unittests/incrementalParser.ts
+++ b/tests/cases/unittests/incrementalParser.ts
@@ -24,8 +24,8 @@ module ts {
    }

    function assertSameDiagnostics(file1: SourceFile, file2: SourceFile) {
-        var diagnostics1 = getSyntacticDiagnostics(file1);
-        var diagnostics2 = getSyntacticDiagnostics(file2);
+        var diagnostics1 = file1.parseDiagnostics;
+        var diagnostics2 = file2.parseDiagnostics;

        assert.equal(diagnostics1.length, diagnostics2.length, "diagnostics1.length !== diagnostics2.length");
        for (var i = 0, n = diagnostics1.length; i < n; i++) {