From e8066158eba22aff78d6899d0bc0dc67b20404d4 Mon Sep 17 00:00:00 2001
From: Yuichi Nukiyama <oscar.wilde84@hotmail.co.jp>
Date: Mon, 1 Aug 2016 15:15:11 +0900
Subject: [PATCH] change error message for unused parameter property

fix
---
 src/compiler/checker.ts                       |  2 +-
 src/compiler/diagnosticMessages.json          |  4 ++++
 .../unusedParameterProperty1.errors.txt       | 14 ++++++++++++++
 .../reference/unusedParameterProperty1.js     | 19 +++++++++++++++++++
 .../unusedParameterProperty2.errors.txt       | 14 ++++++++++++++
 .../reference/unusedParameterProperty2.js     | 19 +++++++++++++++++++
 .../compiler/unusedParameterProperty1.ts      |  9 +++++++++
 .../compiler/unusedParameterProperty2.ts      |  9 +++++++++
 8 files changed, 89 insertions(+), 1 deletion(-)
 create mode 100644 tests/baselines/reference/unusedParameterProperty1.errors.txt
 create mode 100644 tests/baselines/reference/unusedParameterProperty1.js
 create mode 100644 tests/baselines/reference/unusedParameterProperty2.errors.txt
 create mode 100644 tests/baselines/reference/unusedParameterProperty2.js
 create mode 100644 tests/cases/compiler/unusedParameterProperty1.ts
 create mode 100644 tests/cases/compiler/unusedParameterProperty2.ts

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
index 7b85189b784..4b12e2e61f5 100644
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -14967,7 +14967,7 @@ namespace ts {
                         else if (member.kind === SyntaxKind.Constructor) {
                             for (const parameter of (<ConstructorDeclaration>member).parameters) {
                                 if (!parameter.symbol.isReferenced && parameter.flags & NodeFlags.Private) {
-                                    error(parameter.name, Diagnostics._0_is_declared_but_never_used, parameter.symbol.name);
+                                    error(parameter.name, Diagnostics.Property_0_is_declared_but_never_used, parameter.symbol.name);
                                 }
                             }
                         }
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
index 8126d5c605e..c1eead94f14 100644
--- a/src/compiler/diagnosticMessages.json
+++ b/src/compiler/diagnosticMessages.json
@@ -2828,6 +2828,10 @@
         "category": "Message",
         "code": 6137
     },
+    "Property '{0}' is declared but never used.": {
+        "category": "Error",
+        "code": 6138
+    },
     "Variable '{0}' implicitly has an '{1}' type.": {
         "category": "Error",
         "code": 7005
diff --git a/tests/baselines/reference/unusedParameterProperty1.errors.txt b/tests/baselines/reference/unusedParameterProperty1.errors.txt
new file mode 100644
index 00000000000..0581199313f
--- /dev/null
+++ b/tests/baselines/reference/unusedParameterProperty1.errors.txt
@@ -0,0 +1,14 @@
+tests/cases/compiler/unusedParameterProperty1.ts(3,25): error TS6138: Property 'used' is declared but never used.
+
+
+==== tests/cases/compiler/unusedParameterProperty1.ts (1 errors) ====
+    
+    class A {
+        constructor(private used: string) {
+                            ~~~~
+!!! error TS6138: Property 'used' is declared but never used.
+            let foge = used;
+            foge += "";
+        }
+    }
+    
\ No newline at end of file
diff --git a/tests/baselines/reference/unusedParameterProperty1.js b/tests/baselines/reference/unusedParameterProperty1.js
new file mode 100644
index 00000000000..d0b608a6d87
--- /dev/null
+++ b/tests/baselines/reference/unusedParameterProperty1.js
@@ -0,0 +1,19 @@
+//// [unusedParameterProperty1.ts]
+
+class A {
+    constructor(private used: string) {
+        let foge = used;
+        foge += "";
+    }
+}
+
+
+//// [unusedParameterProperty1.js]
+var A = (function () {
+    function A(used) {
+        this.used = used;
+        var foge = used;
+        foge += "";
+    }
+    return A;
+}());
diff --git a/tests/baselines/reference/unusedParameterProperty2.errors.txt b/tests/baselines/reference/unusedParameterProperty2.errors.txt
new file mode 100644
index 00000000000..cb3b3e95556
--- /dev/null
+++ b/tests/baselines/reference/unusedParameterProperty2.errors.txt
@@ -0,0 +1,14 @@
+tests/cases/compiler/unusedParameterProperty2.ts(3,25): error TS6138: Property 'used' is declared but never used.
+
+
+==== tests/cases/compiler/unusedParameterProperty2.ts (1 errors) ====
+    
+    class A {
+        constructor(private used) {
+                            ~~~~
+!!! error TS6138: Property 'used' is declared but never used.
+            let foge = used;
+            foge += "";
+        }
+    }
+    
\ No newline at end of file
diff --git a/tests/baselines/reference/unusedParameterProperty2.js b/tests/baselines/reference/unusedParameterProperty2.js
new file mode 100644
index 00000000000..2bb04fde088
--- /dev/null
+++ b/tests/baselines/reference/unusedParameterProperty2.js
@@ -0,0 +1,19 @@
+//// [unusedParameterProperty2.ts]
+
+class A {
+    constructor(private used) {
+        let foge = used;
+        foge += "";
+    }
+}
+
+
+//// [unusedParameterProperty2.js]
+var A = (function () {
+    function A(used) {
+        this.used = used;
+        var foge = used;
+        foge += "";
+    }
+    return A;
+}());
diff --git a/tests/cases/compiler/unusedParameterProperty1.ts b/tests/cases/compiler/unusedParameterProperty1.ts
new file mode 100644
index 00000000000..61c4374c60a
--- /dev/null
+++ b/tests/cases/compiler/unusedParameterProperty1.ts
@@ -0,0 +1,9 @@
+//@noUnusedLocals:true
+//@noUnusedParameters:true
+
+class A {
+    constructor(private used: string) {
+        let foge = used;
+        foge += "";
+    }
+}
diff --git a/tests/cases/compiler/unusedParameterProperty2.ts b/tests/cases/compiler/unusedParameterProperty2.ts
new file mode 100644
index 00000000000..b9e05fbc967
--- /dev/null
+++ b/tests/cases/compiler/unusedParameterProperty2.ts
@@ -0,0 +1,9 @@
+//@noUnusedLocals:true
+//@noUnusedParameters:true
+
+class A {
+    constructor(private used) {
+        let foge = used;
+        foge += "";
+    }
+}