microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-27 23:49:51 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(51820): disallow using readonly and declare with auto-accessor (#51824)

Browse Source
This commit is contained in:
Oleksandr T
2022-12-20 23:25:33 +02:00
committed by GitHub
parent 6f4d340458
commit e73a51d5d7
4 changed files with 25 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/compiler/checker.ts
View File

@@ -45580,6 +45580,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
// If node.kind === SyntaxKind.Parameter, checkParameter reports an error if it's not a parameter property.
return grammarErrorOnNode(modifier, Diagnostics.readonly_modifier_can_only_appear_on_a_property_declaration_or_index_signature);
}
else if (flags & ModifierFlags.Accessor) {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_cannot_be_used_with_1_modifier, "readonly", "accessor");
}
flags |= ModifierFlags.Readonly;
break;
@@ -45637,6 +45640,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
else if (isPrivateIdentifierClassElementDeclaration(node)) {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_cannot_be_used_with_a_private_identifier, "declare");
}
else if (flags & ModifierFlags.Accessor) {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_cannot_be_used_with_1_modifier, "declare", "accessor");
}
flags |= ModifierFlags.Ambient;
lastDeclare = modifier;
break;