From e5d810384cd64e194a29f4b73dc43d8335dbad2c Mon Sep 17 00:00:00 2001
From: Mohamed Hegazy <mhegazy@microsoft.com>
Date: Wed, 23 Jul 2014 17:41:37 -0700
Subject: [PATCH] remove dependency on settings

---
 src/services/pullLanguageService.ts | 8 +++++++-
 src/services/typescriptServices.ts  | 1 -
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/services/pullLanguageService.ts b/src/services/pullLanguageService.ts
index bd112a97fd3..c8926cd4a5f 100644
--- a/src/services/pullLanguageService.ts
+++ b/src/services/pullLanguageService.ts
@@ -480,8 +480,14 @@ module TypeScript.Services {
             var oldProgram = this.program;
             if (oldProgram) {
                 var oldSettings = this.program.getCompilerOptions();
+
+                // If the language version changed, then that affects what types of things we parse. So
+                // we have to dump all syntax trees.
+                // TODO: handle propagateEnumConstants
+                var settingsChangeAffectsSyntax = oldSettings.target !== compilationSettings.target;
+
                 var changesInCompilationSettingsAffectSyntax =
-                    oldSettings && compilationSettings && !compareDataObjects(oldSettings, compilationSettings) && settingsChangeAffectsSyntax(oldSettings, compilationSettings);
+                    oldSettings && compilationSettings && !compareDataObjects(oldSettings, compilationSettings) && settingsChangeAffectsSyntax;
                 var oldSourceFiles = this.program.getSourceFiles();
 
                 for (var i = 0, n = oldSourceFiles.length; i < n; i++) {
diff --git a/src/services/typescriptServices.ts b/src/services/typescriptServices.ts
index 21ae5f6a6fa..4e272126874 100644
--- a/src/services/typescriptServices.ts
+++ b/src/services/typescriptServices.ts
@@ -46,7 +46,6 @@
 /// <reference path='compiler\referenceResolution.ts' />
 /// <reference path='compiler\precompile.ts' />
 /// <reference path='compiler\bloomFilter.ts' />
-/// <reference path='compiler\settings.ts' />
 /// <reference path='compiler\flags.ts' />
 /// <reference path='compiler\types.ts' />
 /// <reference path='compiler\ast.ts' />