From e335a360c854b45d14d8fa34f89f8c6565a8d133 Mon Sep 17 00:00:00 2001
From: Andy <anhans@microsoft.com>
Date: Fri, 9 Nov 2018 12:48:47 -0800
Subject: [PATCH] Change 'if' in combined switch case to two separate cases
 (#28444)

---
 src/services/refactors/convertExport.ts | 39 ++++++++++++-------------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/src/services/refactors/convertExport.ts b/src/services/refactors/convertExport.ts
index 60729d85487..64c7e7567b8 100644
--- a/src/services/refactors/convertExport.ts
+++ b/src/services/refactors/convertExport.ts
@@ -166,38 +166,35 @@ namespace ts.refactor {
     }
 
     function changeNamedToDefaultImport(importingSourceFile: SourceFile, ref: Identifier, changes: textChanges.ChangeTracker): void {
-        const { parent } = ref;
+        const parent = ref.parent as PropertyAccessExpression | ImportSpecifier | ExportSpecifier;
         switch (parent.kind) {
             case SyntaxKind.PropertyAccessExpression:
                 // `a.foo` --> `a.default`
                 changes.replaceNode(importingSourceFile, ref, createIdentifier("default"));
                 break;
-            case SyntaxKind.ImportSpecifier:
-            case SyntaxKind.ExportSpecifier: {
-                const spec = parent as ImportSpecifier | ExportSpecifier;
-                if (spec.kind === SyntaxKind.ImportSpecifier) {
-                    // `import { foo } from "./a";` --> `import foo from "./a";`
-                    // `import { foo as bar } from "./a";` --> `import bar from "./a";`
-                    const defaultImport = createIdentifier(spec.name.text);
-                    if (spec.parent.elements.length === 1) {
-                        changes.replaceNode(importingSourceFile, spec.parent, defaultImport);
-                    }
-                    else {
-                        changes.delete(importingSourceFile, spec);
-                        changes.insertNodeBefore(importingSourceFile, spec.parent, defaultImport);
-                    }
+            case SyntaxKind.ImportSpecifier: {
+                // `import { foo } from "./a";` --> `import foo from "./a";`
+                // `import { foo as bar } from "./a";` --> `import bar from "./a";`
+                const defaultImport = createIdentifier(parent.name.text);
+                if (parent.parent.elements.length === 1) {
+                    changes.replaceNode(importingSourceFile, parent.parent, defaultImport);
                 }
                 else {
-                    // `export { foo } from "./a";` --> `export { default as foo } from "./a";`
-                    // `export { foo as bar } from "./a";` --> `export { default as bar } from "./a";`
-                    // `export { foo as default } from "./a";` --> `export { default } from "./a";`
-                    // (Because `export foo from "./a";` isn't valid syntax.)
-                    changes.replaceNode(importingSourceFile, spec, makeExportSpecifier("default", spec.name.text));
+                    changes.delete(importingSourceFile, parent);
+                    changes.insertNodeBefore(importingSourceFile, parent.parent, defaultImport);
                 }
                 break;
             }
+            case SyntaxKind.ExportSpecifier: {
+                // `export { foo } from "./a";` --> `export { default as foo } from "./a";`
+                // `export { foo as bar } from "./a";` --> `export { default as bar } from "./a";`
+                // `export { foo as default } from "./a";` --> `export { default } from "./a";`
+                // (Because `export foo from "./a";` isn't valid syntax.)
+                changes.replaceNode(importingSourceFile, parent, makeExportSpecifier("default", parent.name.text));
+                break;
+            }
             default:
-                Debug.failBadSyntaxKind(parent);
+                Debug.assertNever(parent);
         }
 
     }