microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-16 07:13:45 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

In getSymbolAtLocation, return undefined instead of unknownSymbol (#21774)

Browse Source 
* In getSymbolAtLocation, return undefined instead of unknownSymbol

* Update check in completions to look for undefined instead of unknownSymbol
This commit is contained in:
Andy
2018-02-08 14:35:21 -08:00
committed by GitHub
parent 16f3b93ffd
commit e2178ecfab
60 changed files with 37 additions and 372 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/checker.ts
View File

@@ -24628,7 +24628,8 @@ namespace ts {
if (entityName.kind === SyntaxKind.Identifier) {
if (isJSXTagName(entityName) && isJsxIntrinsicIdentifier(entityName)) {
return getIntrinsicTagSymbol(<JsxOpeningLikeElement>entityName.parent);
const symbol = getIntrinsicTagSymbol(<JsxOpeningLikeElement>entityName.parent);
return symbol === unknownSymbol ? undefined : symbol;
}
return resolveEntityName(entityName, SymbolFlags.Value, /*ignoreErrors*/ false, /*dontResolveAlias*/ true);

5
src/services/completions.ts
View File

@@ -923,9 +923,8 @@ namespace ts.Completions {
}
else if (isStartingCloseTag) {
const tagName = (<JsxElement>contextToken.parent.parent).openingElement.tagName;
const tagSymbol = Debug.assertDefined(typeChecker.getSymbolAtLocation(tagName));
if (!typeChecker.isUnknownSymbol(tagSymbol)) {
const tagSymbol = typeChecker.getSymbolAtLocation(tagName);
if (tagSymbol) {
symbols = [tagSymbol];
}
completionKind = CompletionKind.MemberLike;