microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix type checking of variables named "exports" (#52209)

Browse Source
This commit is contained in:
Tobeyyy 2023-01-20 01:59:07 +01:00 committed by GitHub
parent cfe1842adf
commit e01ced050c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@ -36500,7 +36500,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
if (checkReferenceExpression(left,
Diagnostics.The_left_hand_side_of_an_assignment_expression_must_be_a_variable_or_a_property_access,
Diagnostics.The_left_hand_side_of_an_assignment_expression_may_not_be_an_optional_property_access)
&& (!isIdentifier(left) || unescapeLeadingUnderscores(left.escapedText) !== "exports")) {
) {
let headMessage: DiagnosticMessage | undefined;
if (exactOptionalPropertyTypes && isPropertyAccessExpression(left) && maybeTypeOfKind(valueType, TypeFlags.Undefined)) {

8
tests/baselines/reference/typeCheckExportsVariable.errors.txt Normal file
View File

@ -0,0 +1,8 @@
tests/cases/compiler/typeCheckExportsVariable.ts(2,1): error TS2322: Type 'string' is not assignable to type 'number'.
==== tests/cases/compiler/typeCheckExportsVariable.ts (1 errors) ====
let exports: number;
exports = '';
~~~~~~~
!!! error TS2322: Type 'string' is not assignable to type 'number'.

7
tests/baselines/reference/typeCheckExportsVariable.js Normal file
View File

@ -0,0 +1,7 @@
//// [typeCheckExportsVariable.ts]
let exports: number;
exports = '';
//// [typeCheckExportsVariable.js]
var exports;
exports = '';

7
tests/baselines/reference/typeCheckExportsVariable.symbols Normal file
View File

@ -0,0 +1,7 @@
=== tests/cases/compiler/typeCheckExportsVariable.ts ===
let exports: number;
>exports : Symbol(exports, Decl(typeCheckExportsVariable.ts, 0, 3))
exports = '';
>exports : Symbol(exports, Decl(typeCheckExportsVariable.ts, 0, 3))

9
tests/baselines/reference/typeCheckExportsVariable.types Normal file
View File

@ -0,0 +1,9 @@
=== tests/cases/compiler/typeCheckExportsVariable.ts ===
let exports: number;
>exports : number
exports = '';
>exports = '' : ""
>exports : number
>'' : ""

3
tests/cases/compiler/typeCheckExportsVariable.ts Normal file
View File

@ -0,0 +1,3 @@
let exports: number;
exports = '';