Incremental false with composite not allowed

This commit is contained in:
Sheetal Nandi 2019-02-28 15:39:04 -08:00
parent 46ddbff7b1
commit df9da15abb
10 changed files with 1768 additions and 2 deletions

View File

@ -4028,6 +4028,10 @@
"category": "Message",
"code": 6378
},
"Composite projects may not disable incremental compilation.": {
"category": "Error",
"code": 6379
},
"The expected type comes from property '{0}' which is declared here on type '{1}'": {
"category": "Message",

View File

@ -2720,6 +2720,9 @@ namespace ts {
if (options.declaration === false) {
createDiagnosticForOptionName(Diagnostics.Composite_projects_may_not_disable_declaration_emit, "declaration");
}
if (options.incremental === false) {
createDiagnosticForOptionName(Diagnostics.Composite_projects_may_not_disable_declaration_emit, "declaration");
}
}
verifyProjectReferences();

View File

@ -416,10 +416,20 @@ namespace ts {
modifyFs: noop
});
// Verify baseline with and without build info
// Verify baseline with build info
verifyOutFileScenario({
scenario: "when final project is not composite but uses project references",
modifyFs: fs => replaceText(fs, sources[project.third][source.config], `"composite": true,`, ""),
ignoreWithoutBuildInfo: true,
ignoreDtsChanged: true,
ignoreDtsUnchanged: true,
baselineOnly: true
});
// Verify baseline with and without build info
verifyOutFileScenario({
scenario: "when final project is not composite but incremental",
modifyFs: fs => replaceText(fs, sources[project.third][source.config], `"composite": true,`, `"incremental": true,`),
ignoreDtsChanged: true,
ignoreDtsUnchanged: true,
baselineOnly: true

View File

@ -0,0 +1,7 @@
error TS6304: Composite projects may not disable declaration emit.
!!! error TS6304: Composite projects may not disable declaration emit.
==== tests/cases/compiler/optionsCompositeWithIncrementalFalse.ts (0 errors) ====
const x = "Hello World";

View File

@ -0,0 +1,10 @@
//// [optionsCompositeWithIncrementalFalse.ts]
const x = "Hello World";
//// [optionsCompositeWithIncrementalFalse.js]
var x = "Hello World";
//// [optionsCompositeWithIncrementalFalse.d.ts]
declare const x = "Hello World";

View File

@ -0,0 +1,4 @@
=== tests/cases/compiler/optionsCompositeWithIncrementalFalse.ts ===
const x = "Hello World";
>x : Symbol(x, Decl(optionsCompositeWithIncrementalFalse.ts, 0, 5))

View File

@ -0,0 +1,5 @@
=== tests/cases/compiler/optionsCompositeWithIncrementalFalse.ts ===
const x = "Hello World";
>x : "Hello World"
>"Hello World" : "Hello World"

View File

@ -1431,7 +1431,7 @@ sourceFile:../../third_part1.ts
{
"compilerOptions": {
"target": "es5",
"incremental": true,
"removeComments": true,
"strict": false,
"sourceMap": true,

View File

@ -0,0 +1,4 @@
// @composite: true
// @incremental: false
const x = "Hello World";