microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 04:43:37 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Allow assignment to readonly parameter property within the constructor

Browse Source
This commit is contained in:
Andy Hanson
2016-05-20 08:54:05 -07:00
parent f95f51fefc
commit dcbaadaa60
5 changed files with 63 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/compiler/checker.ts
View File

@@ -11882,8 +11882,18 @@ namespace ts {
if (symbol.flags & SymbolFlags.Property &&
(expr.kind === SyntaxKind.PropertyAccessExpression || expr.kind === SyntaxKind.ElementAccessExpression) &&
(expr as PropertyAccessExpression | ElementAccessExpression).expression.kind === SyntaxKind.ThisKeyword) {
const func = getContainingFunction(expr);
return !(func && func.kind === SyntaxKind.Constructor && func.parent === symbol.valueDeclaration.parent);
return !isInConstructor(getContainingFunction(expr));
function isInConstructor(func: FunctionLikeDeclaration) {
if (!func)
return false;
if (func.kind !== SyntaxKind.Constructor)
return false;
if (func.parent === symbol.valueDeclaration.parent) // If the symbol was declared in the class:
return true;
if (func === symbol.valueDeclaration.parent) // If symbolDecl is a parameter property of the constructor:
return true;
return false;
}
}
return true;
}