microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-25 16:07:52 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

feat(18147): skip uncessary parenthesis (#44769)

Browse Source
This commit is contained in:
Oleksandr T
2021-08-17 03:20:40 +03:00
committed by GitHub
parent 424464d46b
commit dc80e6a28b
5 changed files with 72 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/refactors/extractSymbol.ts
View File

@@ -1141,7 +1141,7 @@ namespace ts.refactor.extractSymbol {
? undefined
: checker.typeToTypeNode(checker.getContextualType(node)!, scope, NodeBuilderFlags.NoTruncation); // TODO: GH#18217
let initializer = transformConstantInitializer(node, substitutions);
let initializer = transformConstantInitializer(skipParentheses(node), substitutions);
({ variableType, initializer } = transformFunctionInitializerAndType(variableType, initializer));
@@ -1375,7 +1375,7 @@ namespace ts.refactor.extractSymbol {
}
let returnValueProperty: string | undefined;
let ignoreReturns = false;
const statements = factory.createNodeArray(isBlock(body) ? body.statements.slice(0) : [isStatement(body) ? body : factory.createReturnStatement(body as Expression)]);
const statements = factory.createNodeArray(isBlock(body) ? body.statements.slice(0) : [isStatement(body) ? body : factory.createReturnStatement(skipParentheses(body as Expression))]);
// rewrite body if either there are writes that should be propagated back via return statements or there are substitutions
if (hasWritesOrVariableDeclarations || substitutions.size) {
const rewrittenStatements = visitNodes(statements, visitor).slice();