microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-11 10:46:28 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

report extraneous jsx attribute error on attribute name instead of entire attribute assignment

Browse Source
This commit is contained in:
Nathan Fenner
2019-09-18 14:42:38 -07:00
parent 940231785e
commit dbc17229f7
12 changed files with 22 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/compiler/checker.ts
View File

@@ -13040,15 +13040,10 @@ namespace ts {
// JsxAttributes has an object-literal flag and undergo same type-assignablity check as normal object-literal.
// However, using an object-literal error message will be very confusing to the users so we give different a message.
// TODO: Spelling suggestions for excess jsx attributes (needs new diagnostic messages)
if (errorNode && isJsxOpeningLikeElement(errorNode.parent)) {
const attributes = errorNode.parent.attributes;
for (const jsxProperty of attributes.properties) {
if (jsxProperty.kind === SyntaxKind.JsxAttribute && jsxProperty.name.escapedText === prop.escapedName) {
// Move the error node to the actual JSX property, instead of pointing to the identifier in the JSX element.
errorNode = jsxProperty;
}
}
if (prop.valueDeclaration && isNamedDeclaration(prop.valueDeclaration) && prop.valueDeclaration.name && prop.valueDeclaration.name.pos !== -1) {
// If the "children" attribute is extraneous `<NoChild>extra</NoChild>` then the declaration's name has no location.
// In that case, do not update the error location, since there's no name to point to.
errorNode = prop.valueDeclaration.name;
}
reportError(Diagnostics.Property_0_does_not_exist_on_type_1, symbolToString(prop), typeToString(errorTarget));
}