From d8cdd7552e57ea159866d946255cbcbe49565998 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E6=96=87=E7=92=90?= Date: Thu, 28 Jun 2018 09:36:26 +0800 Subject: [PATCH] do not handle enum type member --- src/services/codefixes/fixAddMissingMember.ts | 2 +- tests/cases/fourslash/codeFixAddMissingEnumMember10.ts | 2 +- tests/cases/fourslash/codeFixAddMissingEnumMember11.ts | 3 +-- tests/cases/fourslash/codeFixAddMissingEnumMember9.ts | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/services/codefixes/fixAddMissingMember.ts b/src/services/codefixes/fixAddMissingMember.ts index bb0dd5a75a5..cd94a910716 100644 --- a/src/services/codefixes/fixAddMissingMember.ts +++ b/src/services/codefixes/fixAddMissingMember.ts @@ -240,7 +240,7 @@ namespace ts.codefix { */ const hasStringInitializer = some(enumDeclaration.members, member => { const type = checker.getTypeAtLocation(member); - return !!(type && type.flags & (TypeFlags.StringLike | TypeFlags.Enum)); + return !!(type && type.flags & TypeFlags.StringLike); }); const enumMember = createEnumMember(token, hasStringInitializer ? createStringLiteral(token.text) : undefined); diff --git a/tests/cases/fourslash/codeFixAddMissingEnumMember10.ts b/tests/cases/fourslash/codeFixAddMissingEnumMember10.ts index 0335c9ef552..dba3051fee9 100644 --- a/tests/cases/fourslash/codeFixAddMissingEnumMember10.ts +++ b/tests/cases/fourslash/codeFixAddMissingEnumMember10.ts @@ -19,7 +19,7 @@ verify.codeFix({ } enum A { a = E.c, - b = "b" + b } A.b` }); diff --git a/tests/cases/fourslash/codeFixAddMissingEnumMember11.ts b/tests/cases/fourslash/codeFixAddMissingEnumMember11.ts index 6a085fc285a..4928b52dba6 100644 --- a/tests/cases/fourslash/codeFixAddMissingEnumMember11.ts +++ b/tests/cases/fourslash/codeFixAddMissingEnumMember11.ts @@ -25,8 +25,7 @@ enum A { } enum B { b = A.a, - c = "c" + c } B.c` }); - diff --git a/tests/cases/fourslash/codeFixAddMissingEnumMember9.ts b/tests/cases/fourslash/codeFixAddMissingEnumMember9.ts index 03bde7c1fce..acc27a6a4ea 100644 --- a/tests/cases/fourslash/codeFixAddMissingEnumMember9.ts +++ b/tests/cases/fourslash/codeFixAddMissingEnumMember9.ts @@ -19,7 +19,7 @@ verify.codeFix({ } enum A { a = E.a, - b = "b" + b } A.b` });