microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-07-07 18:25:51 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

forbid duplicate var exports

Browse Source
This commit is contained in:
Wesley Wigham
2015-10-06 17:59:14 -07:00
parent b9800f09b7
commit d8aa469a7d
17 changed files with 356 additions and 443 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/compiler/checker.ts
View File

@@ -13729,7 +13729,26 @@ namespace ts {
let declaration = getDeclarationOfAliasSymbol(exportEqualsSymbol) || exportEqualsSymbol.valueDeclaration;
error(declaration, Diagnostics.An_export_assignment_cannot_be_used_in_a_module_with_other_exported_elements);
}
getExportsOfModule(moduleSymbol); // Checks for export * conflicts
let exports = getExportsOfModule(moduleSymbol); // Checks for export * conflicts
for (let id in exports) {
if (id === "__export") continue;
if (!(exports[id].flags & SymbolFlags.Namespace || exports[id].flags & SymbolFlags.Interface) && exports[id].declarations.length > 1) { // 15.2.1.1 It is a Syntax Error if the ExportedNames of ModuleItemList contains any duplicate entries. (TS Exceptions: namespaces, function overloads, and interfaces)
let exportedDeclarations: Declaration[] = [];
for (let declaration of exports[id].declarations) {
if (declaration.kind === SyntaxKind.FunctionDeclaration) {
if (!(declaration as FunctionDeclaration).body) {
continue;
}
}
exportedDeclarations.push(declaration);
}
if (exportedDeclarations.length > 1) {
for (let declaration of exportedDeclarations) {
diagnostics.add(createDiagnosticForNode(declaration, Diagnostics.Cannot_redeclare_exported_variable_0, id));
}
}
}
}
links.exportsChecked = true;
}
}

4
src/compiler/diagnosticMessages.json
View File

@@ -892,6 +892,10 @@
"category": "Error",
"code": 2322
},
"Cannot redeclare exported variable '{0}'.": {
"category": "Error",
"code": 2323
},
"Property '{0}' is missing in type '{1}'.": {
"category": "Error",
"code": 2324