From d6fc3fc2daaf9cd91fcc69f79d626d421ec0b84f Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Tue, 23 Sep 2014 15:41:04 -0700 Subject: [PATCH] Code review feedback. --- src/compiler/checker.ts | 4 +--- src/services/services.ts | 6 +++++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index b30128af96f..227e99b712d 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -6544,9 +6544,7 @@ module ts { // If it is a constant value (not undefined), it is syntactically constrained to be a number. // Also, we do not need to check this for ambients because there is already // a syntax error if it is not a constant. - if (fullTypeCheck) { - checkTypeAssignableTo(checkExpression(initializer), enumType, initializer, /*chainedMessage*/ undefined, /*terminalMessage*/ undefined); - } + checkTypeAssignableTo(checkExpression(initializer), enumType, initializer, /*chainedMessage*/ undefined, /*terminalMessage*/ undefined); } } else if (ambient) { diff --git a/src/services/services.ts b/src/services/services.ts index adaeed119c9..8282677ffd4 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -45,6 +45,7 @@ module ts { getFlags(): SymbolFlags; getName(): string; getDeclarations(): Declaration[]; + getDocumentationComment(): string; } export interface Type { @@ -222,6 +223,9 @@ module ts { flags: SymbolFlags; name: string; declarations: Declaration[]; + + // Undefined is used to indicate the value has not been computed. If, after computing, the + // symbol has no doc comment, then the empty string will be returned. documentationComment: string; constructor(flags: SymbolFlags, name: string) { @@ -2390,7 +2394,7 @@ module ts { return undefined; } - var symbol = typeInfoResolver.getSymbolInfo(node); + var symbol = typeInfoResolver.getSymbolInfo(node); if (!symbol) { return undefined; }