From d2445b6286e31996234035bc3bd2ba116be7d639 Mon Sep 17 00:00:00 2001 From: Sheetal Nandi Date: Wed, 11 Nov 2015 16:10:23 -0800 Subject: [PATCH] PR feedback --- src/compiler/program.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/compiler/program.ts b/src/compiler/program.ts index 8f807ed7b86..efaeb825184 100644 --- a/src/compiler/program.ts +++ b/src/compiler/program.ts @@ -327,7 +327,6 @@ namespace ts { let files: SourceFile[] = []; let fileProcessingDiagnostics = createDiagnosticCollection(); const programDiagnostics = createDiagnosticCollection(); - const emitBlockingDiagnostics = createDiagnosticCollection(); let commonSourceDirectory: string; let diagnosticsProducingTypeChecker: TypeChecker; @@ -835,7 +834,6 @@ namespace ts { const allDiagnostics: Diagnostic[] = []; addRange(allDiagnostics, fileProcessingDiagnostics.getGlobalDiagnostics()); addRange(allDiagnostics, programDiagnostics.getGlobalDiagnostics()); - addRange(allDiagnostics, emitBlockingDiagnostics.getGlobalDiagnostics()); return sortAndDeduplicateDiagnostics(allDiagnostics); } @@ -1263,7 +1261,7 @@ namespace ts { }); } - // Verify that all the emit files are unique and dont overwrite input files + // Verify that all the emit files are unique and don't overwrite input files function verifyEmitFilePath(emitFileName: string, emitFilesSeen: FileMap) { if (emitFileName) { const emitFilePath = toPath(emitFileName, currentDirectory, getCanonicalFileName); @@ -1286,7 +1284,7 @@ namespace ts { function createEmitBlockingDiagnostics(emitFileName: string, message: DiagnosticMessage) { hasEmitBlockingDiagnostics.set(toPath(emitFileName, currentDirectory, getCanonicalFileName), true); - emitBlockingDiagnostics.add(createCompilerDiagnostic(message, emitFileName)); + programDiagnostics.add(createCompilerDiagnostic(message, emitFileName)); } } }