microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-19 01:33:15 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Change sortText for class member completions (#48196)

Browse Source 
* change sortText for class member completions

* update test

* create new sort text member for class snippets

* change values of sort text enum
This commit is contained in:
Gabriela Araujo Britto
2022-03-16 20:04:08 -03:00
committed by GitHub
parent f12922c8f7
commit cf8ed8fec1
24 changed files with 165 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/services/completions.ts
View File

@@ -17,14 +17,15 @@ namespace ts.Completions {
SuggestedClassMembers = "14",
GlobalsOrKeywords = "15",
AutoImportSuggestions = "16",
JavascriptIdentifiers = "17",
DeprecatedLocalDeclarationPriority = "18",
DeprecatedLocationPriority = "19",
DeprecatedOptionalMember = "20",
DeprecatedMemberDeclaredBySpreadAssignment = "21",
DeprecatedSuggestedClassMembers = "22",
DeprecatedGlobalsOrKeywords = "23",
DeprecatedAutoImportSuggestions = "24"
ClassMemberSnippets = "17",
JavascriptIdentifiers = "18",
DeprecatedLocalDeclarationPriority = "19",
DeprecatedLocationPriority = "20",
DeprecatedOptionalMember = "21",
DeprecatedMemberDeclaredBySpreadAssignment = "22",
DeprecatedSuggestedClassMembers = "23",
DeprecatedGlobalsOrKeywords = "24",
DeprecatedAutoImportSuggestions = "25"
}
const enum SortTextId {
@@ -37,8 +38,8 @@ namespace ts.Completions {
AutoImportSuggestions = 16,
// Don't use these directly.
_JavaScriptIdentifiers = 17,
_DeprecatedStart = 18,
_JavaScriptIdentifiers = 18,
_DeprecatedStart = 19,
_First = LocalDeclarationPriority,
DeprecatedOffset = _DeprecatedStart - _First,
@@ -769,6 +770,7 @@ namespace ts.Completions {
isClassLikeMemberCompletion(symbol, location)) {
let importAdder;
({ insertText, isSnippet, importAdder, replacementSpan } = getEntryForMemberCompletion(host, program, options, preferences, name, symbol, location, contextToken, formatContext));
sortText = SortText.ClassMemberSnippets; // sortText has to be lower priority than the sortText for keywords. See #47852.
if (importAdder?.hasFixes()) {
hasAction = true;
source = CompletionSource.ClassMemberSnippet;