microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-07 14:13:54 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

add/remove comments

Browse Source
This commit is contained in:
Pranav Senthilnathan (from Dev Box) 2023-10-25 12:55:59 -07:00
parent c7cb038b61
commit cf1bf06933
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/services/completions.ts
View File

@ -3685,17 +3685,16 @@ function getCompletionData(
: undefined;
const nameSymbol = name && typeChecker.getSymbolAtLocation(name);
const nameSymbolId = nameSymbol && getSymbolId(nameSymbol);
if (!nameSymbolId) {
if (!nameSymbolId) { // Not a property access or entity name
addLiteralSymbol();
return;
}
if (addToSeen(seenPropertySymbols, nameSymbolId)) {
const leftMostName = getLeftMostName(computedPropertyNameExpression); // The completion is for `Symbol`, not `iterator`.
const leftMostName = getLeftMostName(computedPropertyNameExpression);
const leftMostNameSymbol = leftMostName && typeChecker.getSymbolAtLocation(leftMostName);
// If this is nested like for `namespace N { export const sym = Symbol(); }`, we'll add the completion for `N`.
const firstAccessibleSymbol = leftMostNameSymbol && getFirstSymbolInChain(leftMostNameSymbol, contextToken, typeChecker);
if (!firstAccessibleSymbol) {
if (!firstAccessibleSymbol) { // Symbol is not accessible from completion location
addLiteralSymbol();
return;
}
@ -3766,6 +3765,9 @@ function getCompletionData(
symbols.push(symbol);
}
/** Combines a property access expression (from the completion location to the left-most name in the computed property expression)
* and the computed property expression itself to return an expression to access the computed property from the completion location.
* Assumes that the left-most symbol is accessible so there should always be a way to access the computed property symbolically. */
function createComputedPropertyAccess(nameSymbol: Symbol, leftMostNameSymbol: Symbol, computedPropertyNameExpression: Expression) {
let node: Node | undefined;
if (!isTransientSymbol(nameSymbol)) {