microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-13 06:20:23 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Object literals can only have properties that exist in contextual type

Browse Source
This commit is contained in:
Anders Hejlsberg 2015-07-08 19:04:58 -07:00
parent 1344b14bd5
commit cd0d3babe9
3 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/compiler/checker.ts
View File

@ -6830,6 +6830,18 @@ namespace ts {
return links.resolvedType;
}
function isPermittedProperty(contextualType: Type, propName: string): boolean {
if (contextualType.flags & TypeFlags.ObjectType) {
let resolved = resolveStructuredTypeMembers(<ObjectType>contextualType);
return !!(resolved.properties.length === 0 || resolved.stringIndexType ||
resolved.numberIndexType || getPropertyOfObjectType(contextualType, propName));
}
if (contextualType.flags & TypeFlags.UnionOrIntersection) {
return !forEach((<UnionOrIntersectionType>contextualType).types, type => !isPermittedProperty(type, propName));
}
return true;
}
function checkObjectLiteral(node: ObjectLiteralExpression, contextualMapper?: TypeMapper): Type {
// Grammar checking
checkGrammarObjectLiteralExpression(node);
@ -6879,6 +6891,9 @@ namespace ts {
if (!hasDynamicName(memberDecl)) {
propertiesTable[member.name] = member;
if (contextualType && !isPermittedProperty(contextualType, member.name)) {
error(memberDecl.name, Diagnostics.Property_0_does_not_exist_in_contextual_type_1, member.name, typeToString(contextualType));
}
}
propertiesArray.push(member);
}

1
src/compiler/diagnosticInformationMap.generated.ts
View File

@ -414,6 +414,7 @@ namespace ts {
The_arguments_object_cannot_be_referenced_in_an_async_arrow_function_Consider_using_a_standard_async_function_expression: { code: 2522, category: DiagnosticCategory.Error, key: "The 'arguments' object cannot be referenced in an async arrow function. Consider using a standard async function expression." },
yield_expressions_cannot_be_used_in_a_parameter_initializer: { code: 2523, category: DiagnosticCategory.Error, key: "'yield' expressions cannot be used in a parameter initializer." },
await_expressions_cannot_be_used_in_a_parameter_initializer: { code: 2524, category: DiagnosticCategory.Error, key: "'await' expressions cannot be used in a parameter initializer." },
Property_0_does_not_exist_in_contextual_type_1: { code: 2525, category: DiagnosticCategory.Error, key: "Property '{0}' does not exist in contextual type '{1}'." },
JSX_element_attributes_type_0_must_be_an_object_type: { code: 2600, category: DiagnosticCategory.Error, key: "JSX element attributes type '{0}' must be an object type." },
The_return_type_of_a_JSX_element_constructor_must_return_an_object_type: { code: 2601, category: DiagnosticCategory.Error, key: "The return type of a JSX element constructor must return an object type." },
JSX_element_implicitly_has_type_any_because_the_global_type_JSX_Element_does_not_exist: { code: 2602, category: DiagnosticCategory.Error, key: "JSX element implicitly has type 'any' because the global type 'JSX.Element' does not exist." },

4
src/compiler/diagnosticMessages.json
View File

@ -1645,6 +1645,10 @@
"category": "Error",
"code": 2524
},
"Property '{0}' does not exist in contextual type '{1}'.": {
"category": "Error",
"code": 2525
},
"JSX element attributes type '{0}' must be an object type.": {
"category": "Error",
"code": 2600