From c459bb7ce9eb88bb1918adf862330418ddb36e57 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Tue, 24 Mar 2015 00:25:23 -0700 Subject: [PATCH] CR feedback. --- src/services/services.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/services/services.ts b/src/services/services.ts index bfff0522f93..b24a51f3db7 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -2443,8 +2443,8 @@ module ts { }; } - function getCompletionData(fileName: string, position: number, symbolName?: string): { symbols: Symbol[], isMemberCompletion: boolean, isNewIdentifierLocation: boolean, location: Node } { - let result = getCompletionSymbolsWorker(fileName, position, symbolName); + function getCompletionData(fileName: string, position: number, symbolName?: string) { + let result = getCompletionDataWorker(fileName, position, symbolName); if (!result) { return undefined; } @@ -2457,7 +2457,7 @@ module ts { return result; } - function getCompletionSymbolsWorker(fileName: string, position: number, symbolName: string): { symbols: Symbol[], isMemberCompletion: boolean, isNewIdentifierLocation: boolean, location: Node }{ + function getCompletionDataWorker(fileName: string, position: number, symbolName: string) { let syntacticStart = new Date().getTime(); let sourceFile = getValidSourceFile(fileName); @@ -2590,8 +2590,8 @@ module ts { let symbolMeanings = SymbolFlags.Type | SymbolFlags.Value | SymbolFlags.Namespace | SymbolFlags.Alias; // Filter down to the symbol that matches the symbolName if we were given one. - let predicate: (s: Symbol) => boolean = symbolName - ? s => getValidCompletionEntryDisplayName(s, target) === symbolName + let predicate = symbolName !== undefined + ? (s: Symbol) => getValidCompletionEntryDisplayName(s, target) === symbolName : undefined; symbols = typeInfoResolver.getSymbolsInScope(scopeNode, symbolMeanings, predicate); }