microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-12-11 00:55:01 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fixed a printer crash caused by empty parameter modifiers (#60537)

Browse Source
This commit is contained in:
Mateusz Burzyński 2025-06-30 20:14:10 +02:00 committed by GitHub
parent b46556e7b7
commit c33f83ac9b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/expressionToTypeNode.ts
View File

@ -1113,7 +1113,7 @@ export function createSyntacticTypeNodeBuilder(
function ensureParameter(p: ParameterDeclaration, context: SyntacticTypeNodeBuilderContext) {
return factory.updateParameterDeclaration(
p,
[],
/*modifiers*/ undefined,
reuseNode(context, p.dotDotDotToken),
resolver.serializeNameOfParameter(context, p),
resolver.isOptionalParameter(p) ? factory.createToken(SyntaxKind.QuestionToken) : undefined,

31
tests/cases/fourslash/completionEntryClassMembersWithInferredFunctionReturnType1.ts Normal file
View File

@ -0,0 +1,31 @@
///<reference path="fourslash.ts" />
// @filename: /tokenizer.ts
//// export default abstract class Tokenizer {
//// errorBuilder() {
//// return (pos: number, lineStart: number, curLine: number) => {};
//// }
//// }
// @filename: /expression.ts
//// import Tokenizer from "./tokenizer.js";
////
//// export default abstract class ExpressionParser extends Tokenizer {
//// /**/
//// }
verify.completions({
marker: "",
includes: [
{
name: "errorBuilder",
insertText: "errorBuilder(): (pos: number, lineStart: number, curLine: number) => void {\n}",
filterText: "errorBuilder",
},
],
preferences: {
includeCompletionsWithInsertText: true,
includeCompletionsWithClassMemberSnippets: true,
},
isNewIdentifierLocation: true,
});