microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Remove object literal freshness in control flow based array types (#39518)

Browse Source 
* Remove object literal freshness in control flow based array types

* Add regression test
This commit is contained in:
Anders Hejlsberg 2020-07-10 10:18:15 -07:00 committed by GitHub
parent 87a74aa9ce
commit c335aad665
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 73 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@ -20633,7 +20633,7 @@ namespace ts {
// we defer subtype reduction until the evolving array type is finalized into a manifest
// array type.
function addEvolvingArrayElementType(evolvingArrayType: EvolvingArrayType, node: Expression): EvolvingArrayType {
const elementType = getBaseTypeOfLiteralType(getContextFreeTypeOfExpression(node));
const elementType = getRegularTypeOfObjectLiteral(getBaseTypeOfLiteralType(getContextFreeTypeOfExpression(node)));
return isTypeSubsetOf(elementType, evolvingArrayType.elementType) ? evolvingArrayType : getEvolvingArrayType(getUnionType([evolvingArrayType.elementType, elementType]));
}

14
tests/baselines/reference/controlFlowArrays.js
View File

@ -176,7 +176,16 @@ function f18() {
x.unshift("hello");
x[2] = true;
return x; // (string | number | boolean)[]
}
}
// Repro from #39470
declare function foo(arg: { val: number }[]): void;
let arr = []
arr.push({ val: 1, bar: 2 });
foo(arr);
//// [controlFlowArrays.js]
function f1() {
@ -340,3 +349,6 @@ function f18() {
x[2] = true;
return x; // (string | number | boolean)[]
}
var arr = [];
arr.push({ val: 1, bar: 2 });
foo(arr);

22
tests/baselines/reference/controlFlowArrays.symbols
View File

@ -467,3 +467,25 @@ function f18() {
return x; // (string | number | boolean)[]
>x : Symbol(x, Decl(controlFlowArrays.ts, 172, 7))
}
// Repro from #39470
declare function foo(arg: { val: number }[]): void;
>foo : Symbol(foo, Decl(controlFlowArrays.ts, 177, 1))
>arg : Symbol(arg, Decl(controlFlowArrays.ts, 181, 21))
>val : Symbol(val, Decl(controlFlowArrays.ts, 181, 27))
let arr = []
>arr : Symbol(arr, Decl(controlFlowArrays.ts, 183, 3))
arr.push({ val: 1, bar: 2 });
>arr.push : Symbol(Array.push, Decl(lib.es5.d.ts, --, --))
>arr : Symbol(arr, Decl(controlFlowArrays.ts, 183, 3))
>push : Symbol(Array.push, Decl(lib.es5.d.ts, --, --))
>val : Symbol(val, Decl(controlFlowArrays.ts, 184, 10))
>bar : Symbol(bar, Decl(controlFlowArrays.ts, 184, 18))
foo(arr);
>foo : Symbol(foo, Decl(controlFlowArrays.ts, 177, 1))
>arr : Symbol(arr, Decl(controlFlowArrays.ts, 183, 3))

28
tests/baselines/reference/controlFlowArrays.types
View File

@ -612,3 +612,31 @@ function f18() {
return x; // (string | number | boolean)[]
>x : (string | number | boolean)[]
}
// Repro from #39470
declare function foo(arg: { val: number }[]): void;
>foo : (arg: { val: number;}[]) => void
>arg : { val: number; }[]
>val : number
let arr = []
>arr : any[]
>[] : never[]
arr.push({ val: 1, bar: 2 });
>arr.push({ val: 1, bar: 2 }) : number
>arr.push : (...items: any[]) => number
>arr : any[]
>push : (...items: any[]) => number
>{ val: 1, bar: 2 } : { val: number; bar: number; }
>val : number
>1 : 1
>bar : number
>2 : 2
foo(arr);
>foo(arr) : void
>foo : (arg: { val: number; }[]) => void
>arr : { val: number; bar: number; }[]

10
tests/cases/compiler/controlFlowArrays.ts
View File

@ -178,4 +178,12 @@ function f18() {
x.unshift("hello");
x[2] = true;
return x; // (string | number | boolean)[]
}
}
// Repro from #39470
declare function foo(arg: { val: number }[]): void;
let arr = []
arr.push({ val: 1, bar: 2 });
foo(arr);