From bf3fbe347ac7f4ec42d2403eb17fb799f90fcf44 Mon Sep 17 00:00:00 2001 From: Vladimir Matveev Date: Mon, 11 Aug 2014 22:34:58 -0700 Subject: [PATCH] adressed CR feedback: use pos instead of full start --- src/services/outliningElementsCollector.ts | 2 +- src/services/services.ts | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/services/outliningElementsCollector.ts b/src/services/outliningElementsCollector.ts index b713c4d2934..53509ec3c1f 100644 --- a/src/services/outliningElementsCollector.ts +++ b/src/services/outliningElementsCollector.ts @@ -40,7 +40,7 @@ module ts { if (node && startElement && endElement) { var span: OutliningSpan = { textSpan: TypeScript.TextSpan.fromBounds(startElement.pos, endElement.end), - hintSpan: TypeScript.TextSpan.fromBounds(node.getFullStart(), node.end), + hintSpan: TypeScript.TextSpan.fromBounds(node.pos, node.end), bannerText: "...", autoCollapse: false }; diff --git a/src/services/services.ts b/src/services/services.ts index 9635b5ab534..515f18e6601 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -1014,9 +1014,8 @@ module ts { // walk over the nodes and set parent references var parent: Node = sourceFile; function walk(n: Node): void { - if (parent) { - n.parent = parent; - } + n.parent = parent; + var saveParent = parent; parent = n; forEachChild(n, walk);