From bdd8a3e8786426128e10f9778de1a2cdfd2de1d5 Mon Sep 17 00:00:00 2001 From: Andrew Branch Date: Mon, 8 Jul 2019 16:32:53 -0700 Subject: [PATCH] Only add "Did you forget await" for function args when the parameter type is not promise-like --- src/compiler/checker.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 471a2c56742..943eb2f3df5 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -21453,6 +21453,10 @@ namespace ts { function maybeAddMissingAwaitInfo(errorNode: Node | undefined, source: Type, target: Type) { if (errorNode && reportErrors && errorOutputContainer.errors && errorOutputContainer.errors.length) { + // Bail if target is Promise-like---something else is wrong + if (getAwaitedTypeOfPromise(target)) { + return; + } const awaitedTypeOfSource = getAwaitedTypeOfPromise(source); if (awaitedTypeOfSource && isTypeRelatedTo(awaitedTypeOfSource, target, relation)) { addRelatedInfo(errorOutputContainer.errors[0], createDiagnosticForNode(errorNode, Diagnostics.Did_you_forget_to_use_await));