From 82dc484ccb072fe4cfcadc730e2a1dd9650114b5 Mon Sep 17 00:00:00 2001 From: zhengbli Date: Thu, 13 Aug 2015 12:59:19 -0700 Subject: [PATCH 1/4] Fix ImageData constructor --- src/lib/dom.es6.d.ts | 4 ++++ src/lib/dom.generated.d.ts | 8 +++----- src/lib/webworker.generated.d.ts | 8 +++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/lib/dom.es6.d.ts b/src/lib/dom.es6.d.ts index 8702201bb9e..97981524a45 100644 --- a/src/lib/dom.es6.d.ts +++ b/src/lib/dom.es6.d.ts @@ -8,4 +8,8 @@ interface NodeList { interface NodeListOf { [Symbol.iterator](): IterableIterator +} + +interface ImageData { + new(array: Uint8ClampedArray, width: number, height: number): ImageData; } \ No newline at end of file diff --git a/src/lib/dom.generated.d.ts b/src/lib/dom.generated.d.ts index 8eec72f1a4c..d24906dc9d6 100644 --- a/src/lib/dom.generated.d.ts +++ b/src/lib/dom.generated.d.ts @@ -7014,12 +7014,10 @@ interface ImageData { data: number[]; height: number; width: number; + new(width: number, height: number): ImageData; } -declare var ImageData: { - prototype: ImageData; - new(): ImageData; -} +declare var ImageData: ImageData; interface KeyboardEvent extends UIEvent { altKey: boolean; @@ -12952,4 +12950,4 @@ declare function addEventListener(type: "unload", listener: (ev: Event) => any, declare function addEventListener(type: "volumechange", listener: (ev: Event) => any, useCapture?: boolean): void; declare function addEventListener(type: "waiting", listener: (ev: Event) => any, useCapture?: boolean): void; declare function addEventListener(type: "wheel", listener: (ev: WheelEvent) => any, useCapture?: boolean): void; -declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void; +declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void; diff --git a/src/lib/webworker.generated.d.ts b/src/lib/webworker.generated.d.ts index db8b02f34d7..9fa3153be18 100644 --- a/src/lib/webworker.generated.d.ts +++ b/src/lib/webworker.generated.d.ts @@ -430,12 +430,10 @@ interface ImageData { data: number[]; height: number; width: number; + new(width: number, height: number): ImageData; } -declare var ImageData: { - prototype: ImageData; - new(): ImageData; -} +declare var ImageData: ImageData; interface MSApp { clearTemporaryWebDataAsync(): MSAppAsyncOperation; @@ -861,4 +859,4 @@ declare function postMessage(data: any): void; declare var console: Console; declare function addEventListener(type: "error", listener: (ev: ErrorEvent) => any, useCapture?: boolean): void; declare function addEventListener(type: "message", listener: (ev: MessageEvent) => any, useCapture?: boolean): void; -declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void; \ No newline at end of file +declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void; From 37c0acf4c2d0b0fb2df6d62e98dfecd9f28069cf Mon Sep 17 00:00:00 2001 From: zhengbli Date: Thu, 13 Aug 2015 13:48:25 -0700 Subject: [PATCH 2/4] CR feedback --- src/lib/dom.es6.d.ts | 2 +- src/lib/dom.generated.d.ts | 6 +++++- src/lib/webworker.generated.d.ts | 6 +++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/lib/dom.es6.d.ts b/src/lib/dom.es6.d.ts index 97981524a45..c74c5352a9f 100644 --- a/src/lib/dom.es6.d.ts +++ b/src/lib/dom.es6.d.ts @@ -10,6 +10,6 @@ interface NodeListOf { [Symbol.iterator](): IterableIterator } -interface ImageData { +interface ImageDataConstructor { new(array: Uint8ClampedArray, width: number, height: number): ImageData; } \ No newline at end of file diff --git a/src/lib/dom.generated.d.ts b/src/lib/dom.generated.d.ts index d24906dc9d6..c6098659e7e 100644 --- a/src/lib/dom.generated.d.ts +++ b/src/lib/dom.generated.d.ts @@ -7014,10 +7014,14 @@ interface ImageData { data: number[]; height: number; width: number; +} + +interface ImageDataConstructor { + prototype: ImageData; new(width: number, height: number): ImageData; } -declare var ImageData: ImageData; +declare var ImageData: ImageDataConstructor; interface KeyboardEvent extends UIEvent { altKey: boolean; diff --git a/src/lib/webworker.generated.d.ts b/src/lib/webworker.generated.d.ts index 9fa3153be18..2efbe32306c 100644 --- a/src/lib/webworker.generated.d.ts +++ b/src/lib/webworker.generated.d.ts @@ -430,10 +430,14 @@ interface ImageData { data: number[]; height: number; width: number; +} + +interface ImageDataConstructor { + prototype: ImageData; new(width: number, height: number): ImageData; } -declare var ImageData: ImageData; +declare var ImageData: ImageDataConstructor; interface MSApp { clearTemporaryWebDataAsync(): MSAppAsyncOperation; From 831d2eb13751c3c52c9151ec8eed808b20bcc733 Mon Sep 17 00:00:00 2001 From: zhengbli Date: Wed, 19 Aug 2015 15:01:23 -0700 Subject: [PATCH 3/4] Move back the constructor signature with Uint8ClampedArray --- src/lib/dom.generated.d.ts | 1 + src/lib/webworker.generated.d.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/lib/dom.generated.d.ts b/src/lib/dom.generated.d.ts index 134b5f6c41c..a12154bb04d 100644 --- a/src/lib/dom.generated.d.ts +++ b/src/lib/dom.generated.d.ts @@ -7019,6 +7019,7 @@ interface ImageData { interface ImageDataConstructor { prototype: ImageData; new(width: number, height: number): ImageData; + new(array: Uint8ClampedArray, width: number, height: number): ImageData; } declare var ImageData: ImageDataConstructor; diff --git a/src/lib/webworker.generated.d.ts b/src/lib/webworker.generated.d.ts index 38dd00958dc..900c7e538ec 100644 --- a/src/lib/webworker.generated.d.ts +++ b/src/lib/webworker.generated.d.ts @@ -468,6 +468,7 @@ interface ImageData { interface ImageDataConstructor { prototype: ImageData; new(width: number, height: number): ImageData; + new(array: Uint8ClampedArray, width: number, height: number): ImageData; } declare var ImageData: ImageDataConstructor; From df3ecab074a27962956482e8609651acc2069270 Mon Sep 17 00:00:00 2001 From: zhengbli Date: Wed, 19 Aug 2015 15:02:37 -0700 Subject: [PATCH 4/4] Remove duplicated code --- src/lib/dom.es6.d.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/lib/dom.es6.d.ts b/src/lib/dom.es6.d.ts index c74c5352a9f..e83b8531011 100644 --- a/src/lib/dom.es6.d.ts +++ b/src/lib/dom.es6.d.ts @@ -9,7 +9,3 @@ interface NodeList { interface NodeListOf { [Symbol.iterator](): IterableIterator } - -interface ImageDataConstructor { - new(array: Uint8ClampedArray, width: number, height: number): ImageData; -} \ No newline at end of file