microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-04 21:53:42 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Unconditionally use WeakMap in debug (#51785)

Browse Source
This commit is contained in:
Jake Bailey 2022-12-06 10:41:39 -08:00 committed by GitHub
parent c2fa967bff
commit bb42b5c1a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/compiler/debug.ts
View File

@ -588,23 +588,8 @@ export namespace Debug {
if (isDebugInfoEnabled) return;
// avoid recomputing
let weakTypeTextMap: WeakMap<Type, string> | undefined;
let weakNodeTextMap: WeakMap<Node, string> | undefined;
function getWeakTypeTextMap() {
if (weakTypeTextMap === undefined) {
if (typeof WeakMap === "function") weakTypeTextMap = new WeakMap();
}
return weakTypeTextMap;
}
function getWeakNodeTextMap() {
if (weakNodeTextMap === undefined) {
if (typeof WeakMap === "function") weakNodeTextMap = new WeakMap();
}
return weakNodeTextMap;
}
const weakTypeTextMap = new WeakMap<Type, string>();
const weakNodeTextMap = new WeakMap<Node, string>();
// Add additional properties in debug mode to assist with debugging.
Object.defineProperties(objectAllocator.getSymbolConstructor().prototype, {
@ -658,11 +643,10 @@ export namespace Debug {
__debugTypeToString: {
value(this: Type) {
// avoid recomputing
const map = getWeakTypeTextMap();
let text = map?.get(this);
let text = weakTypeTextMap.get(this);
if (text === undefined) {
text = this.checker.typeToString(this);
map?.set(this, text);
weakTypeTextMap.set(this, text);
}
return text;
}
@ -738,13 +722,12 @@ export namespace Debug {
value(this: Node, includeTrivia?: boolean) {
if (nodeIsSynthesized(this)) return "";
// avoid recomputing
const map = getWeakNodeTextMap();
let text = map?.get(this);
let text = weakNodeTextMap.get(this);
if (text === undefined) {
const parseNode = getParseTreeNode(this);
const sourceFile = parseNode && getSourceFileOfNode(parseNode);
text = sourceFile ? getSourceTextOfNodeFromSourceFile(sourceFile, parseNode, includeTrivia) : "";
map?.set(this, text);
weakNodeTextMap.set(this, text);
}
return text;
}