From b6f4aa9da9052ee77091c5d07a8f87de2b0ebc4c Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 23 Oct 2014 14:08:04 -0700 Subject: [PATCH] Fix wrong condition for unterminated multi-line comments --- src/services/services.ts | 6 +++--- tests/cases/fourslash/completionListInComments3.ts | 9 +++++++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/services/services.ts b/src/services/services.ts index cf04ba101b6..3584e016227 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -2025,9 +2025,9 @@ module ts { return true; } else { - // is unterminated multiline comment - return text.charCodeAt(comment.end - 1) !== CharacterCodes.slash && - text.charCodeAt(comment.end - 2) !== CharacterCodes.asterisk; + // is unterminated multi-line comment + return !(text.charCodeAt(comment.end - 1) === CharacterCodes.slash && + text.charCodeAt(comment.end - 2) === CharacterCodes.asterisk); } } return false; diff --git a/tests/cases/fourslash/completionListInComments3.ts b/tests/cases/fourslash/completionListInComments3.ts index 3f57929c1f4..2f20a969ba1 100644 --- a/tests/cases/fourslash/completionListInComments3.ts +++ b/tests/cases/fourslash/completionListInComments3.ts @@ -10,6 +10,8 @@ //// {| "name": "5" |}/* */ +/////* {| "name": "6" |} + goTo.marker("1"); verify.completionListIsEmpty(); @@ -22,5 +24,8 @@ verify.completionListIsEmpty(); goTo.marker("4"); verify.not.completionListIsEmpty(); -//goTo.marker("5"); -//verify.not.completionListIsEmpty(); +goTo.marker("5"); +verify.not.completionListIsEmpty(); + +goTo.marker("6"); +verify.completionListIsEmpty();