Remove jake (hopefully for real this time) (#29085)

* Remove jake (hopefully for real this time)

* Fix gulpfile non-lkg build, add sanity-check build to posttest on CI, accept older baseline style to go with lkgd build

* More docs/scripts jake -> gulp

scripts/bisect-test.ts

@@ -15,6 +15,7 @@ function tsc(tscArgs: string, onExit: (exitCode: number) => void) {
     });
 }
 
+// TODO: Rewrite bisect script to handle the post-jake/gulp swap period
 var jake = cp.exec('jake clean local', () => void 0);
 jake.on('close', jakeExitCode => {
     if (jakeExitCode === 0) {

scripts/build/tests.js

@@ -116,6 +116,17 @@ async function runConsoleTests(runJs, defaultReporter, runInParallel, watchMode,
             errorStatus = exitCode;
             error = new Error(`Process exited with status code ${errorStatus}.`);
         }
+        else if (process.env.CI === "true") {
+            // finally, do a sanity check and build the compiler with the built version of itself
+            log.info("Starting sanity check build...");
+            // Cleanup everything except lint rules (we'll need those later and would rather not waste time rebuilding them)
+            await exec("gulp", ["clean-tsc", "clean-services", "clean-tsserver", "clean-lssl", "clean-tests"], { cancelToken });
+            const { exitCode } = await exec("gulp", ["local", "--lkg=false"], { cancelToken });
+            if (exitCode !== 0) {
+                errorStatus = exitCode;
+                error = new Error(`Sanity check build process exited with status code ${errorStatus}.`);
+            }
+        }
     }
     catch (e) {
         errorStatus = undefined;
@@ -148,7 +159,7 @@ async function cleanTestDirs() {
 exports.cleanTestDirs = cleanTestDirs;
 
 /**
- * used to pass data from jake command line directly to run.js
+ * used to pass data from gulp command line directly to run.js
  * @param {string} tests
  * @param {string} runners
  * @param {boolean} light

scripts/hooks/post-checkout

@@ -1,2 +1,2 @@
 #!/bin/sh
-npm run jake -- generate-diagnostics
+npm run gulp -- generate-diagnostics

scripts/open-user-pr.ts

@@ -24,7 +24,7 @@ const branchName = `user-update-${now.getFullYear()}${padNum(now.getMonth())}${p
 const remoteUrl = `https://${process.argv[2]}@github.com/${userName}/TypeScript.git`;
 runSequence([
     ["git", ["checkout", "."]], // reset any changes
-    ["node", ["./node_modules/jake/bin/cli.js", "baseline-accept"]], // accept baselines
+    ["node", ["./node_modules/gulp/bin/gulp.js", "baseline-accept"]], // accept baselines
     ["git", ["checkout", "-b", branchName]], // create a branch
     ["git", ["add", "."]], // Add all changes
     ["git", ["commit", "-m", `"Update user baselines"`]], // Commit all changes