From b21c1fd5955768fd20a5b7e095da0628f6c7be85 Mon Sep 17 00:00:00 2001
From: Andy <anhans@microsoft.com>
Date: Fri, 20 Jul 2018 11:10:33 -0700
Subject: [PATCH] `errorCodes` in `CodeFixRequestArgs` is non-optional (#25815)

---
 src/server/protocol.ts                             | 2 +-
 src/server/session.ts                              | 5 +----
 tests/baselines/reference/api/tsserverlibrary.d.ts | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/server/protocol.ts b/src/server/protocol.ts
index 2e5218f754d..a04b7fe5da8 100644
--- a/src/server/protocol.ts
+++ b/src/server/protocol.ts
@@ -705,7 +705,7 @@ namespace ts.server.protocol {
         /**
          * Errorcodes we want to get the fixes for.
          */
-        errorCodes?: ReadonlyArray<number>;
+        errorCodes: ReadonlyArray<number>;
     }
 
     export interface GetCombinedCodeFixRequestArgs {
diff --git a/src/server/session.ts b/src/server/session.ts
index 385a1d3abe9..2777da3aee2 100644
--- a/src/server/session.ts
+++ b/src/server/session.ts
@@ -1767,15 +1767,12 @@ namespace ts.server {
         }
 
         private getCodeFixes(args: protocol.CodeFixRequestArgs, simplifiedResult: boolean): ReadonlyArray<protocol.CodeFixAction> | ReadonlyArray<CodeFixAction> | undefined {
-            if (args.errorCodes!.length === 0) { // TODO: GH#18217
-                return undefined;
-            }
             const { file, project } = this.getFileAndProject(args);
 
             const scriptInfo = project.getScriptInfoForNormalizedPath(file)!;
             const { startPosition, endPosition } = this.getStartAndEndPosition(args, scriptInfo);
 
-            const codeActions = project.getLanguageService().getCodeFixesAtPosition(file, startPosition, endPosition, args.errorCodes!, this.getFormatOptions(file), this.getPreferences(file));
+            const codeActions = project.getLanguageService().getCodeFixesAtPosition(file, startPosition, endPosition, args.errorCodes, this.getFormatOptions(file), this.getPreferences(file));
             return simplifiedResult ? codeActions.map(codeAction => this.mapCodeFixAction(codeAction)) : codeActions;
         }
 
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
index 360f311c48f..eede4badc7e 100644
--- a/tests/baselines/reference/api/tsserverlibrary.d.ts
+++ b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -6280,7 +6280,7 @@ declare namespace ts.server.protocol {
         /**
          * Errorcodes we want to get the fixes for.
          */
-        errorCodes?: ReadonlyArray<number>;
+        errorCodes: ReadonlyArray<number>;
     }
     interface GetCombinedCodeFixRequestArgs {
         scope: GetCombinedCodeFixScope;