fix type import check for default-import/re-export in js files (#57778)

This commit is contained in:
Lyu, Wei-Da 2024-03-28 06:08:18 +08:00 committed by GitHub
parent f3f70df94e
commit b0d5ae6091
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 61 additions and 1 deletions

View File

@ -2706,7 +2706,8 @@ export function getCompletionEntriesFromSymbols(
}
function symbolAppearsToBeTypeOnly(symbol: Symbol): boolean {
return !(symbol.flags & SymbolFlags.Value) && (!isInJSFile(symbol.declarations?.[0]) || !!(symbol.flags & SymbolFlags.Type));
const flags = getCombinedLocalAndExportSymbolFlags(skipAlias(symbol, typeChecker));
return !(flags & SymbolFlags.Value) && (!isInJSFile(symbol.declarations?.[0]) || !!(flags & SymbolFlags.Type));
}
}

View File

@ -0,0 +1,59 @@
/// <reference path="fourslash.ts" />
// @allowJs: true
// @Filename: /default.ts
//// export default class TestDefaultClass {}
// @Filename: /defaultType.ts
//// export default interface TestDefaultInterface {}
// @Filename: /reExport/toReExport.ts
//// export class TestClassReExport {}
//// export interface TestInterfaceReExport {}
// @Filename: /reExport/index.ts
//// export { TestClassReExport, TestInterfaceReExport } from './toReExport';
// @Filename: /exportList.ts
//// class TestClassExportList {};
//// interface TestInterfaceExportList {};
//// export { TestClassExportList, TestInterfaceExportList };
// @Filename: /baseline.ts
//// export class TestClassBaseline {}
//// export interface TestInterfaceBaseline {}
// @Filename: /a.js
//// import /**/
verify.completions({
marker: "",
isNewIdentifierLocation: true,
exact: [
{
name: "TestClassBaseline",
insertText: "import { TestClassBaseline } from \"./baseline\";",
source: "./baseline",
},
{
name: "TestClassExportList",
insertText: "import { TestClassExportList } from \"./exportList\";",
source: "./exportList",
},
{
name: "TestClassReExport",
insertText: "import { TestClassReExport } from \"./reExport\";",
source: "./reExport",
},
{
name: "TestDefaultClass",
insertText: "import TestDefaultClass from \"./default\";",
source: "./default",
},
],
preferences: {
includeCompletionsForImportStatements: true,
includeCompletionsWithInsertText: true,
}
});