From b05f2bf1a3ebbd0a1967c63d5cd6852d396f4bad Mon Sep 17 00:00:00 2001 From: Vladimir Matveev Date: Fri, 23 Jan 2015 17:08:30 -0800 Subject: [PATCH] handle binding patterns correctly when getting script lexical structure --- src/services/navigationBar.ts | 2 +- .../cases/fourslash/scriptLexicalStructureBindingPatterns.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/scriptLexicalStructureBindingPatterns.ts diff --git a/src/services/navigationBar.ts b/src/services/navigationBar.ts index 9051ee80399..5ffcc6e1b6a 100644 --- a/src/services/navigationBar.ts +++ b/src/services/navigationBar.ts @@ -51,7 +51,7 @@ module ts.NavigationBar { forEach((node).elements, visit); break; case SyntaxKind.VariableDeclaration: - if (isBindingPattern(node)) { + if (isBindingPattern((node).name)) { visit((node).name); break; } diff --git a/tests/cases/fourslash/scriptLexicalStructureBindingPatterns.ts b/tests/cases/fourslash/scriptLexicalStructureBindingPatterns.ts new file mode 100644 index 00000000000..b3141de5720 --- /dev/null +++ b/tests/cases/fourslash/scriptLexicalStructureBindingPatterns.ts @@ -0,0 +1,4 @@ +/// +////var foo, {} +////var bar, [] +verify.getScriptLexicalStructureListCount(3); // global (1) + variable declarations (2)