From b0321dc177dffae1bbd7ff020386ee648189b47c Mon Sep 17 00:00:00 2001 From: uniqueiniquity Date: Fri, 29 Dec 2017 14:21:55 -0800 Subject: [PATCH] Refactor to avoid errors --- src/server/typingsInstaller/typingsInstaller.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/server/typingsInstaller/typingsInstaller.ts b/src/server/typingsInstaller/typingsInstaller.ts index a3b96a4e02e..22982b60075 100644 --- a/src/server/typingsInstaller/typingsInstaller.ts +++ b/src/server/typingsInstaller/typingsInstaller.ts @@ -55,7 +55,7 @@ namespace ts.server.typingsInstaller { try { if (fileExists) { const content = JSON.parse(host.readFile(typeDeclarationTimestampFilePath)); - return content.entries; + return content.entries || {}; } else { host.writeFile(typeDeclarationTimestampFilePath, "{}"); @@ -247,10 +247,11 @@ namespace ts.server.typingsInstaller { continue; } const existingTypingFile = this.packageNameToTypingLocation.get(packageName); - if (existingTypingFile.typingLocation === typingFile) { - continue; - } if (existingTypingFile) { + if (existingTypingFile.typingLocation === typingFile) { + continue; + } + if (this.log.isEnabled()) { this.log.writeLine(`New typing for package ${packageName} from '${typingFile}' conflicts with existing typing file '${existingTypingFile}'`); }