microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-12-11 09:24:19 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(lib.d.ts): fixed buffer parameter type of DataView (#53130)

Browse Source
This commit is contained in:
Luca Pizzini 2023-04-11 17:19:25 +02:00 committed by GitHub
parent 89a6482d60
commit af5e8e2e4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/es5.d.ts vendored
View File

@ -1814,7 +1814,7 @@ interface DataView {
interface DataViewConstructor {
readonly prototype: DataView;
new(buffer: ArrayBufferLike, byteOffset?: number, byteLength?: number): DataView;
new(buffer: ArrayBufferLike & { BYTES_PER_ELEMENT?: never }, byteOffset?: number, byteLength?: number): DataView;
}
declare var DataView: DataViewConstructor;

13
tests/baselines/reference/dataViewConstructor.errors.txt Normal file
View File

@ -0,0 +1,13 @@
tests/cases/compiler/dataViewConstructor.ts(1,14): error TS2345: Argument of type 'Uint8Array' is not assignable to parameter of type 'ArrayBuffer & { BYTES_PER_ELEMENT?: never; }'.
Type 'Uint8Array' is not assignable to type '{ BYTES_PER_ELEMENT?: never; }'.
Types of property 'BYTES_PER_ELEMENT' are incompatible.
Type 'number' is not assignable to type 'never'.
==== tests/cases/compiler/dataViewConstructor.ts (1 errors) ====
new DataView(new Uint8Array(32)); // should error
~~~~~~~~~~~~~~~~~~
!!! error TS2345: Argument of type 'Uint8Array' is not assignable to parameter of type 'ArrayBuffer & { BYTES_PER_ELEMENT?: never; }'.
!!! error TS2345: Type 'Uint8Array' is not assignable to type '{ BYTES_PER_ELEMENT?: never; }'.
!!! error TS2345: Types of property 'BYTES_PER_ELEMENT' are incompatible.
!!! error TS2345: Type 'number' is not assignable to type 'never'.

5
tests/baselines/reference/dataViewConstructor.js Normal file
View File

@ -0,0 +1,5 @@
//// [dataViewConstructor.ts]
new DataView(new Uint8Array(32)); // should error
//// [dataViewConstructor.js]
new DataView(new Uint8Array(32)); // should error

5
tests/baselines/reference/dataViewConstructor.symbols Normal file
View File

@ -0,0 +1,5 @@
=== tests/cases/compiler/dataViewConstructor.ts ===
new DataView(new Uint8Array(32)); // should error
>DataView : Symbol(DataView, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
>Uint8Array : Symbol(Uint8Array, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))

8
tests/baselines/reference/dataViewConstructor.types Normal file
View File

@ -0,0 +1,8 @@
=== tests/cases/compiler/dataViewConstructor.ts ===
new DataView(new Uint8Array(32)); // should error
>new DataView(new Uint8Array(32)) : DataView
>DataView : DataViewConstructor
>new Uint8Array(32) : Uint8Array
>Uint8Array : Uint8ArrayConstructor
>32 : 32

1
tests/cases/compiler/dataViewConstructor.ts Normal file
View File

@ -0,0 +1 @@
new DataView(new Uint8Array(32)); // should error

2
tests/lib/lib.d.ts vendored
View File

@ -1387,7 +1387,7 @@ interface DataView {
}
interface DataViewConstructor {
new (buffer: ArrayBuffer, byteOffset?: number, byteLength?: number): DataView;
new (buffer: ArrayBuffer & { BYTES_PER_ELEMENT?: never }, byteOffset?: number, byteLength?: number): DataView;
}
declare var DataView: DataViewConstructor;