Fixed string literal completions for partially-typed strings when overload could get matched (#48811)

This commit is contained in:
Mateusz Burzyński 2022-04-22 17:36:14 +02:00 committed by GitHub
parent 71f94c5bdb
commit af30c79093
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions

View File

@ -30501,6 +30501,7 @@ namespace ts {
// decorators are applied to a declaration by the emitter, and not to an expression.
const isSingleNonGenericCandidate = candidates.length === 1 && !candidates[0].typeParameters;
let argCheckMode = !isDecorator && !isSingleNonGenericCandidate && some(args, isContextSensitive) ? CheckMode.SkipContextSensitive : CheckMode.Normal;
argCheckMode |= checkMode & CheckMode.IsForStringLiteralArgumentCompletions;
// The following variables are captured and modified by calls to chooseOverload.
// If overload resolution or type argument inference fails, we want to report the
@ -30726,7 +30727,7 @@ namespace ts {
// If one or more context sensitive arguments were excluded, we start including
// them now (and keeping do so for any subsequent candidates) and perform a second
// round of type inference and applicability checking for this particular candidate.
argCheckMode = CheckMode.Normal;
argCheckMode = checkMode & CheckMode.IsForStringLiteralArgumentCompletions;
if (inferenceContext) {
const typeArgumentTypes = inferTypeArguments(node, candidate, args, argCheckMode, inferenceContext);
checkCandidate = getSignatureInstantiation(candidate, typeArgumentTypes, isInJSFile(candidate.declaration), inferenceContext && inferenceContext.inferredTypeParameters);

View File

@ -0,0 +1,9 @@
/// <reference path="fourslash.ts" />
// @Filename: /a.tsx
//// declare function bar1<P extends "" | "bar" | "baz">(p: P): void;
////
//// bar1("/*ts*/")
////
verify.completions({ marker: ["ts"], exact: ["", "bar", "baz"] });