microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 12:51:30 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fixed an issue with errors not being correctly reported after completion requests in nested calls (#54658)

Browse Source
This commit is contained in:
Mateusz Burzyński
2023-06-20 21:04:08 +02:00
committed by GitHub
parent b1c2e8caad
commit abf0ef8eef
2 changed files with 43 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/compiler/checker.ts
View File

@@ -1828,14 +1828,19 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
};
function runWithoutResolvedSignatureCaching<T>(node: Node | undefined, fn: () => T): T {
const containingCall = findAncestor(node, isCallLikeExpression);
const containingCallResolvedSignature = containingCall && getNodeLinks(containingCall).resolvedSignature;
if (containingCall) {
getNodeLinks(containingCall).resolvedSignature = undefined;
const cachedSignatures = [];
while (node) {
if (isCallLikeExpression(node)) {
const nodeLinks = getNodeLinks(node);
const resolvedSignature = nodeLinks.resolvedSignature;
cachedSignatures.push([nodeLinks, resolvedSignature] as const);
nodeLinks.resolvedSignature = undefined;
}
node = node.parent;
}
const result = fn();
if (containingCall) {
getNodeLinks(containingCall).resolvedSignature = containingCallResolvedSignature;
for (const [nodeLinks, resolvedSignature] of cachedSignatures) {
nodeLinks.resolvedSignature = resolvedSignature;
}
return result;
}