From ab5ce84da84d867b1b2eb18d9199c9cbd4b324e8 Mon Sep 17 00:00:00 2001 From: Jason Freeman Date: Fri, 19 Sep 2014 12:07:50 -0700 Subject: [PATCH] Minor fixes in getSignatureHelpItems --- src/services/services.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/services/services.ts b/src/services/services.ts index c483d771256..170525e8887 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -2268,7 +2268,7 @@ module ts { result.push(getDefinitionInfo(declarations[declarations.length - 1], symbolKind, symbolName, containerName)); return true; } - + return false; } @@ -2469,7 +2469,7 @@ module ts { break; } } - + if (shouldHighlightNextKeyword) { result.push(new ReferenceEntry(filename, TypeScript.TextSpan.fromBounds(elseKeyword.getStart(), ifKeyword.end), /* isWriteAccess */ false)); i++; // skip the next keyword @@ -3581,13 +3581,16 @@ module ts { selectedItemIndex = 0; } - var applicableSpan = new TypeScript.TextSpan(argumentListOrTypeArgumentList.getFullStart(), argumentListOrTypeArgumentList.end); + var applicableSpanStart = argumentListOrTypeArgumentList.getFullStart(); + var applicableSpanEnd = skipTrivia(sourceFile.text, argumentListOrTypeArgumentList.end, /*stopAfterLineBreak*/ false); + var applicableSpan = new TypeScript.TextSpan(applicableSpanStart, applicableSpanEnd - applicableSpanStart); return new SignatureHelpItems(items, applicableSpan, selectedItemIndex); } synchronizeHostData(); // Decide whether to show signature help + fileName = TypeScript.switchToForwardSlashes(fileName); var sourceFile = getSourceFile(fileName); var node = getNodeAtPosition(sourceFile, position);