microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-09 02:30:15 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(56733): Auto fix "add missing properties" of enums does not correct namespace of enum (#56739)

Browse Source
This commit is contained in:
Oleksandr T 2024-01-02 21:25:44 +02:00 committed by GitHub
parent a16895031e
commit a50f67d347
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/codefixes/fixAddMissingMember.ts
View File

@ -674,7 +674,7 @@ function tryGetValueFromType(context: CodeFixContextBase, checker: TypeChecker,
}
if (type.flags & TypeFlags.EnumLike) {
const enumMember = type.symbol.exports ? firstOrUndefinedIterator(type.symbol.exports.values()) : type.symbol;
const name = checker.symbolToExpression(type.symbol.parent ? type.symbol.parent : type.symbol, SymbolFlags.Value, /*enclosingDeclaration*/ undefined, /*flags*/ undefined);
const name = checker.symbolToExpression(type.symbol.parent ? type.symbol.parent : type.symbol, SymbolFlags.Value, /*enclosingDeclaration*/ undefined, /*flags*/ NodeBuilderFlags.UseFullyQualifiedType);
return enumMember === undefined || name === undefined ? factory.createNumericLiteral(0) : factory.createPropertyAccessExpression(name, checker.symbolToString(enumMember));
}
if (type.flags & TypeFlags.NumberLiteral) {

27
tests/cases/fourslash/codeFixAddMissingProperties29.ts Normal file
View File

@ -0,0 +1,27 @@
/// <reference path="fourslash.ts" />
////namespace Foo.Bar {
//// export enum E {
//// E1 = 0,
//// E2 = 1,
//// }
//// export interface Baz {
//// prop1: string;
//// prop2: number;
//// prop3: E.E1;
//// prop4: Foo.Bar.E.E1;
//// }
////}
////[|const foo: Foo.Bar.Baz = {}|]
verify.codeFix({
index: 0,
description: ts.Diagnostics.Add_missing_properties.message,
newRangeContent:
`const foo: Foo.Bar.Baz = {
prop1: "",
prop2: 0,
prop3: Foo.Bar.E.E1,
prop4: Foo.Bar.E.E1
}`,
});