microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-04 03:09:39 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(58146): enum quick info can display non ascii strings (#58171)

Browse Source
This commit is contained in:
idango10 2024-04-12 23:04:03 +03:00 committed by GitHub
parent a9b0d1ee53
commit a4d12a46c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/utilities.ts
View File

@ -1762,7 +1762,7 @@ function canUseOriginalText(node: LiteralLikeNode, flags: GetLiteralTextFlags):
/** @internal */
export function getTextOfConstantValue(value: string | number) {
return isString(value) ? '"' + escapeNonAsciiString(value) + '"' : "" + value;
return isString(value) ? `"${escapeString(value)}"` : "" + value;
}
// Make an identifier from an external module name by extracting the string after the last "/" and replacing

13
tests/cases/fourslash/quickInfoEnumMembersAcceptNonAsciiStrings.ts Normal file
View File

@ -0,0 +1,13 @@
/// <reference path='fourslash.ts' />
//// enum Demo {
//// /*Emoji*/Emoji = '🍎',
//// /*Hebrew*/Hebrew = 'תפוח',
//// /*Chinese*/Chinese = '苹果',
//// /*Japanese*/Japanese = 'りんご',
//// }
verify.quickInfoAt("Emoji", '(enum member) Demo.Emoji = "🍎"');
verify.quickInfoAt("Hebrew",'(enum member) Demo.Hebrew = "תפוח"');
verify.quickInfoAt("Chinese", '(enum member) Demo.Chinese = "苹果"');
verify.quickInfoAt("Japanese",'(enum member) Demo.Japanese = "りんご"');